RE: RFR: 8219585: [TESTBUG] sun/management/jmxremote/bootstrap/JMXInterfaceBindingTest.java passes trivially when it shouldn't

2019-02-24 Thread Sharath Ballal
Nit: you may want to change this message "Ignoring manual test since no more than one IPs are configured for 'localhost'" to "Ignoring manual test since no non loopback IPs are configured for 'localhost'" Thanks, Sharath -Original Message- From: Severin Gehwolf [ma

Re: RFR (S) 8181171: Deleting method for RedefineClasses breaks ResolvedMethodName

2019-02-24 Thread David Holmes
Hi Coleen, On 23/02/2019 9:36 am, coleen.phillim...@oracle.com wrote: 8210457: JVM crash in ResolvedMethodTable::add_method(Handle) Summary: Add a function to call NSME in ResolvedMethodTable to replace deleted methods. Given the existing code just seems to say "I don't know what to do here"

Re: RFR: JDK-8214756: SA should ignore archived java heap objects that are not in use

2019-02-24 Thread Jini George
Thanks a bunch, Claes! - Jini On 2/24/2019 5:25 PM, Claes Redestad wrote: Hi Jini, changes looks good, and thanks for verifying your fix unblock 8214712! /Claes On 2019-02-24 06:01, Jini George wrote: Thank you very much, Jiangli! Yes, I did test open/test/hotspot/jtreg/serviceability/sa/Te

Re: RFR: JDK-8214756: SA should ignore archived java heap objects that are not in use

2019-02-24 Thread Claes Redestad
Hi Jini, changes looks good, and thanks for verifying your fix unblock 8214712! /Claes On 2019-02-24 06:01, Jini George wrote: Thank you very much, Jiangli! Yes, I did test open/test/hotspot/jtreg/serviceability/sa/TestHeapDumpForLargeArray.java after applying the changes from: http://cr.op