Looks good, but what about sp06t003? Doesn't it have the same problem?
Are there any other tests using similar logic?
dl
On 3/1/19 8:33 PM, Daniil Titov wrote:
Please review the change that fix intermittent failure for test
nsk/jvmti/scenarios/sampling/SP02/sp02t003 when running with
Please review the change that fix intermittent failure for test
nsk/jvmti/scenarios/sampling/SP02/sp02t003 when running with Graal.
The problem with the test here is that method checkThread() looks for the test
method in the top "commonDepth" frames where "commonDepth" is a minimum of
+1
thanks,
Chris
On 3/1/19 2:56 PM, David Holmes wrote:
Looks good.
Thanks,
David
On 2/03/2019 7:46 am, Dmitry Chuyko wrote:
Ok. typedef part removed according to review comments (not related to
fix).
Updated webrev: http://cr.openjdk.java.net/~dchuyko/8214854/webrev.01/
-Dmitry
On
On 03/01/2019 04:15, Gary Adams wrote:
I will move the logging statement up.
Leaving the "docontinue" in the synchronized block
will guarantee the debugger suspends the debuggee
main thread without any chance of interference
with logging commands.
I'm sure this test was left with verbose
Looks good.
Thanks,
David
On 2/03/2019 7:46 am, Dmitry Chuyko wrote:
Ok. typedef part removed according to review comments (not related to fix).
Updated webrev: http://cr.openjdk.java.net/~dchuyko/8214854/webrev.01/
-Dmitry
On 3/1/19 10:07 PM, Chris Plummer wrote:
On 2/28/19 11:12 PM,
Ok. typedef part removed according to review comments (not related to fix).
Updated webrev: http://cr.openjdk.java.net/~dchuyko/8214854/webrev.01/
-Dmitry
On 3/1/19 10:07 PM, Chris Plummer wrote:
On 2/28/19 11:12 PM, Dmitry Chuyko wrote:
On 3/1/19 6:36 AM, Chris Plummer wrote:
On 2/28/19
On 2/28/19 11:12 PM, Dmitry Chuyko wrote:
On 3/1/19 6:36 AM, Chris Plummer wrote:
On 2/28/19 5:07 PM, David Holmes wrote:
Hi Dmitry,
On 1/03/2019 6:15 am, Dmitry Chuyko wrote:
Hello,
Please review a small fix for GCC 8.x warning in log_messages.c.
Buffer sizes for parts of timestamp string
Hi Severin,
On 01/03/2019 15:49, Severin Gehwolf wrote:
On Fri, 2019-03-01 at 15:08 +, Daniel Fuchs wrote:
I ran it 50 times in our test system - and it passed on all platforms,
so there's yet hope :-)
Thanks for this! I take it, it actually runs the test on some of those
test systems
On Fri, 2019-03-01 at 15:08 +, Daniel Fuchs wrote:
> I ran it 50 times in our test system - and it passed on all platforms,
> so there's yet hope :-)
Thanks for this! I take it, it actually runs the test on some of those
test systems (no trivial pass)?
Cheers,
Severin
Hi Severin,
On 28/02/2019 15:47, Severin Gehwolf wrote:
Yes, thanks for looking at this Daniel. That was my determination as
well. However, even if we do all of the above, and add a test config
with /etc/hosts mapping a non-loopback address to "localhost" it would
break other tests. E.g. this
I will move the logging statement up.
Leaving the "docontinue" in the synchronized block
will guarantee the debugger suspends the debuggee
main thread without any chance of interference
with logging commands.
I'm sure this test was left with verbose logging enabled in the
hopes of catching more
Dear All,
I have upload a webrev at
http://cr.openjdk.java.net/~xiaofeya/8219721/webrev.00/ (just found there is a
jank file "abc", I will omit it in next webrev, but let's review other changes
first for time saving.)
And here are my comments and questions:
* With this patch , I
12 matches
Mail list logo
