Re: RFR:8219721: jcmd from earlier release will hang attaching to VM with JDK-8215622 applied

2019-03-06 Thread Thomas Stüfe
Neat! Both directions are fixed now: I can connect with new jcmd to old VMs and vice versa. Thanks a lot! ..Thomas On Mon, Mar 4, 2019 at 10:14 AM 臧琳 wrote: > Dear All, >May I ask your help to review the fix of compatibility issue introduced > by JDK-8215622 >webrev: http://cr.openjdk.

Re: 8219721: jcmd from earlier release will hang attaching to VM with JDK-8215622 applied

2019-03-06 Thread Hohensee, Paul
+1. Paul On 3/5/19, 2:44 PM, "serviceability-dev on behalf of serguei.spit...@oracle.com" wrote: Hi Lin, It looks good to me too. Thanks, Serguei On 3/4/19 1:13 AM, 臧琳 wrote: > Dear All, > May I ask your help to review the fix of compatibility is

Re: RFR: JDK-8201252: unquarantine nsk/jdi/ThreadReference/resume/resume001

2019-03-06 Thread Chris Plummer
Looks good. Chris On 3/6/19 7:33 AM, Gary Adams wrote: After 1000's of test runs with the resume001 test off the ProblemList, no new sightings have been observed. I intend to use the JDK-8201252 issue to restore the test. JDK-8072701 will be updated and left for sustaining, if the fix needs to

Re: [8u] [RFR] 8140482: Various minor code improvements (runtime)

2019-03-06 Thread Andrew John Hughes
On 22/11/2018 08:51, Lindenmaier, Goetz wrote: > Hi, > > Doesn't this have to be posted to jdk8u-dev? > > I had a look at the backport. > Including 7127191 confused me a bit. Is it good to hide the fact that > this was backported in the repository? > In os_linux one fix is missing, is this on

Re: 8218464: vmTestbase/nsk/jdi/VirtualMachine/allThreads/allthreads001/TestDescription.java failed

2019-03-06 Thread Daniil Titov
Thank you, Serguei and Gary, for reviewing this change! --Daniil On 3/6/19, 8:57 AM, "Gary Adams" wrote: Looks OK to me. On 3/5/19, 5:47 PM, serguei.spit...@oracle.com wrote: > Hi Daniil, > > The fix looks good. > > Thanks, > Serguei > > > On 3/

Re: RFR: 8218464: vmTestbase/nsk/jdi/VirtualMachine/allThreads/allthreads001/TestDescription.java failed

2019-03-06 Thread Gary Adams
Looks OK to me. On 3/5/19, 5:47 PM, serguei.spit...@oracle.com wrote: Hi Daniil, The fix looks good. Thanks, Serguei On 3/5/19 1:59 PM, Daniil Titov wrote: Please review a fix for this test that intermittently fails with Graal on. The problem here is that the test does two consequent call

RFR: JDK-8201252: unquarantine nsk/jdi/ThreadReference/resume/resume001

2019-03-06 Thread Gary Adams
After 1000's of test runs with the resume001 test off the ProblemList, no new sightings have been observed. I intend to use the JDK-8201252 issue to restore the test. JDK-8072701 will be updated and left for sustaining, if the fix needs to be applied to older releases. diff --git a/test/hotspot/