Re: RFR: JDK-8184770: JDWP support for IPv6

2019-04-01 Thread Alex Menkov
Hi Daniel, As far as I see you are right. Attach to address with empty hostname will try to connect to "external" address instead of loopback. --alex On 04/01/2019 02:51, Daniel Fuchs wrote: Hi Arthur, Not directly related to Alex's original question but... On 30/03/2019 00:03, Arthur Euba

Re: RFR: JDK-8184770: JDWP support for IPv6

2019-04-01 Thread Alex Menkov
On 04/01/2019 05:02, Chris Hegarty wrote: On 01/04/2019 12:50, Chris Hegarty wrote: ... Specifically on SocketTransportService.java. What Arthur has proposed is better ( changing to lastIndexOf alone is not sufficient ). Or is your assumption that the IPv6 literal is not enclosed in square b

Re: RFR: JDK-8184770: JDWP support for IPv6

2019-04-01 Thread Alex Menkov
Hi Chris, On 04/01/2019 04:50, Chris Hegarty wrote: Alex, On 29/03/2019 22:07, Alex Menkov wrote: (added net-dev as suggested by Alan) Net gurus, please assist in reviewing socket-related code. New webrev: http://cr.openjdk.java.net/~amenkov/IPv6/webrev.01/ Specifically on SocketTransportS

Re: RFR: JDK-8184770: JDWP support for IPv6

2019-04-01 Thread Alex Menkov
Hi Daniel, Chris, Unfortunately docs are out-dated (I plan to update it in JDK13). In JDK9 https://bugs.openjdk.java.net/browse/JDK-8041435 changed the behavior - empty address (i.e. only port is specified) means "local connections only", "*" means "all available connections". Then in JDK10 new

Re: RFR: JDK-8184770: JDWP support for IPv6

2019-04-01 Thread Chris Hegarty
On 01/04/2019 10:51, Daniel Fuchs wrote: Hi Arthur, Not directly related to Alex's original question but... On 30/03/2019 00:03, Arthur Eubanks wrote: We have some ipv6 patches as well in this area as well (as well as other patches to support ipv6 only environments) that we're trying to ups

Re: RFR: 8220602: Shenandoah-SA: Enable best-effort implementation of heap walk

2019-04-01 Thread Zhengyu Gu
Hi, May I get review from serviceability? as it has minor changes in shared code (CollectedHeap.java and ObjectHeap.java) Thanks, -Zhengyu On 3/14/19 11:37 AM, Zhengyu Gu wrote: Please review this patch that provides best-effort implementation of live regions iteration for Shenandoah GC.

Re: LingeredApp termination sequence

2019-04-01 Thread Gary Adams
The problem I was trying to understand a little better ... I was observing an IOException, but it was not a NoSuchFileException. Changing to catch just IOException runs cleanly, but may obscure some other cause of the IOException. Testing a variant today that exits cleanly as long as the lock fi

Re: [RFR]8215623: Add incremental dump for jmap histo

2019-04-01 Thread 臧琳
Dear All, Here I updated the latest changeset which did the following refine: * fixed the compatibility issues so that old version of jmap can work normally with latest changeset. * revised the code for parsing the jmap histo arguments. * revised the logic for incremental d

Re: RFR: JDK-8184770: JDWP support for IPv6

2019-04-01 Thread Chris Hegarty
On 01/04/2019 12:50, Chris Hegarty wrote: ... Specifically on SocketTransportService.java. What Arthur has proposed is better ( changing to lastIndexOf alone is not sufficient ). Or is your assumption that the IPv6 literal is not enclosed in square brackets? More specifically, what syntax ar

Re: RFR: JDK-8184770: JDWP support for IPv6

2019-04-01 Thread Chris Hegarty
Alex, On 29/03/2019 22:07, Alex Menkov wrote: (added net-dev as suggested by Alan) Net gurus, please assist in reviewing socket-related code. New webrev: http://cr.openjdk.java.net/~amenkov/IPv6/webrev.01/ Specifically on SocketTransportService.java. What Arthur has proposed is better ( chan

Re: RFR: JDK-8184770: JDWP support for IPv6

2019-04-01 Thread Daniel Fuchs
Hi Arthur, Not directly related to Alex's original question but... On 30/03/2019 00:03, Arthur Eubanks wrote: We have some ipv6 patches as well in this area as well (as well as other patches to support ipv6 only environments) that we're trying to upstream. I don't understand the code myself, b