Hi David, thanks for your comments!
I'm not sure how findComponentType worked in the current state:
Type findComponentType(String signature) throws ClassNotLoadedException {
93 byte tag = (byte)signature.charAt(0);
94 if (PacketStream.isObjectTag(tag)) {
95 // It's a reference type
96 JNITypePar
Bug:
https://bugs.openjdk.java.net/browse/JDK-8221917
Fix:
http://cr.openjdk.java.net/~shade/8221917/webrev.01/
The failure is caused by MDO change in 11 that broke SA a little. I am planning
to backport it all
the way down to 11u. See bug for details.
Testing:
- Linux x86_32 fastdebug: T
Hi Aleksey,
I looked at the changes to this file that were done in JDK-8204240
(which introduced the issue), and your fix seems correct. Thumbs up!
thanks,
Chris
On 4/5/19 8:11 AM, Aleksey Shipilev wrote:
Bug:
https://bugs.openjdk.java.net/browse/JDK-8221917
Fix:
http://cr.openjdk.ja
Thank you, JC and David, for reviewing this change!
Best regards,
-Daniil
From: Jean Christophe Beyler
Date: Friday, April 5, 2019 at 9:40 AM
To: David Holmes
Cc: Daniil Titov , OpenJDK Serviceability
, Thomas Stüfe
Subject: Re: 8221730: jcmd process name matching broken
Hi Daniil,
+1
Please update copyright year.
Thanks,
David
On 6/04/2019 3:31 am, Chris Plummer wrote:
Hi Aleksey,
I looked at the changes to this file that were done in JDK-8204240
(which introduced the issue), and your fix seems correct. Thumbs up!
thanks,
Chris
On 4/5/19 8:11 AM, Aleksey Shipilev
[I just realized I had typed this up a day or two ago and never sent it]
+1, except there is a typo on the following line:
54 * was started with -m or --module option
the method returns
thanks,
Chris
On 4/3/19 5:23 PM, David Holmes wrote:
Hi Daniil,
This seems reasonable, but can
