Re: RFR: JDK-8184770: JDWP support for IPv6

2019-04-12 Thread serguei . spitsyn
Hi Alex, Thank you for the update! One more round of minor formatting change requests for better readability. :) #1: http://cr.openjdk.java.net/~amenkov/IPv6/webrev.03/src/jdk.jdi/share/classes/com/sun/tools/jdi/SocketTransportService.java.udiff.html +    port = Integer.decode(h

Re: RFR: JDK-8184770: JDWP support for IPv6

2019-04-12 Thread Alex Menkov
updated webrev: http://cr.openjdk.java.net/~amenkov/IPv6/webrev.03/ changes (vs webrev.02) are non-functional (added/edited comments, code reformatting, renaming convertIpv4ToIpv6 function to convertIPv4ToIPv6, renaming env variable to jniEnv (env is already used in one of the functions)). A

8157947: SA: Javascript engine can't access internal packages of jdk.hotspot.agent

2019-04-12 Thread Yasumasa Suenaga
Hi all, I saw the message when I attached CLHSDB to target VM as below: javax.script.ScriptException: TypeError: sapkg.runtime.VM.getVM is not a function in sa.js at line number 54 Warning! JS Engine can't start, some commands will not be available. It has been reported as JDK-815794

Re: JDK-8177064: jcmd help command should not require the process identification

2019-04-12 Thread David Holmes
On 12/04/2019 9:47 pm, Gary Adams wrote: On 4/11/19, 8:16 PM, David Holmes wrote: Hi Gary, On 12/04/2019 4:24 am, Gary Adams wrote: Two years ago a request was made to allow     jcmd help to be interpretted as a request for help from the current jcmd process rather than requiring a separate

Re: JDK-8177064: jcmd help command should not require the process identification

2019-04-12 Thread Gary Adams
On 4/11/19, 8:16 PM, David Holmes wrote: Hi Gary, On 12/04/2019 4:24 am, Gary Adams wrote: Two years ago a request was made to allow jcmd help to be interpretted as a request for help from the current jcmd process rather than requiring a separate target process to be involved. Some attem