Hi David,
Thank you for the review!
I'll remove this import.
Thanks,
Serguei
On 4/25/19 22:54, David Holmes wrote:
Hi Serguei,
Thanks for making these additional changes.
On 26/04/2019 12:57 pm, serguei.spit...@oracle.com wrote:
Hi Coleen and Dan,
Updated webrev is:
Hi Serguei,
Thanks for making these additional changes.
On 26/04/2019 12:57 pm, serguei.spit...@oracle.com wrote:
Hi Coleen and Dan,
Updated webrev is:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8222934-jvmti-depr-option.2/
This implements the suggestions:
VMDeprecatedOptions.java:
Hi Coleen and Dan,
Updated webrev is:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8222934-jvmti-depr-option.2/
This implements the suggestions:
VMDeprecatedOptions.java:
- moved the option to the deprecated non-alias flags section
TestAddDeleteMethods.java:
- removed confusion in
Looks good.
dl
On 4/25/19 6:33 PM, Daniil Titov wrote:
Please review the change that fixes an intermittent failure of the test when
running with Graal on.
The test creates exception requests for different kinds of exceptions and
errors, starts the debuggee that throws an exception, and
Please review the change that fixes an intermittent failure of the test when
running with Graal on.
The test creates exception requests for different kinds of exceptions and
errors, starts the debuggee that throws an exception, and listens for exception
events. If the number of received
Hi Ralf,
You added libjava for Windows, but not for other platforms.
Doesn't it need
LIBS_unix := -ljava
?
--alex
On 04/25/2019 17:59, serguei.spit...@oracle.com wrote:
Hi Ralf,
The fix looks good to me.
We agreed that Alex will also look at this.
Thanks,
Serguei
On 4/17/19 1:30 AM,
Hi Ralf,
The fix looks good to me.
We agreed that Alex will also look at this.
Thanks,
Serguei
On 4/17/19 1:30 AM, Schmelter, Ralf wrote:
Can you please review this change, which ensures the sun.jdwp.listenerAddress
property value is created using the platform encoding.
webrev:
Hi Daniil,
Looks good.
Thanks,
Serguei
On 4/25/19 4:34 PM, Daniil Titov wrote:
Please review the change that fixes this test when it is run with Graal on.
The test starts the debugee, creates multiple thread start requests, tells the debuggee
to start a new thread, and listens for the
Please review the change that fixes this test when it is run with Graal on.
The test starts the debugee, creates multiple thread start requests, tells the
debuggee to start a new thread, and listens for the thread start events
received. If the number of the received thread start events doesn't
Thanks Serguei!
David
On 26/04/2019 3:41 am, serguei.spit...@oracle.com wrote:
Hi David,
Looks good.
Thank you for taking care about this!
Thanks,
Serguei
On 4/25/19 01:36, David Holmes wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8222970
Thanks Dan!
David
On 26/04/2019 12:00 am, Daniel D. Daugherty wrote:
Thumbs up!
Dan
On 4/25/19 4:36 AM, David Holmes wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8222970
vmTestbase/nsk/jdb/eval/eval001/eval001.java is ProblemListed under
JDK-8221503 which is now closed as a
Thanks Gary!
David
On 25/04/2019 10:07 pm, Gary Adams wrote:
Looks OK to me.
On 4/25/19, 4:36 AM, David Holmes wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8222970
vmTestbase/nsk/jdb/eval/eval001/eval001.java is ProblemListed under
JDK-8221503 which is now closed as a duplicate of
Hi Coleen,
Thank you a lot for looking at this!
On 4/25/19 2:18 PM, coleen.phillim...@oracle.com wrote:
On 4/25/19 4:19 PM, serguei.spit...@oracle.com wrote:
Hi Dan,
Thank you a lot fore reviewing this!
On 4/25/19 12:40, Daniel D. Daugherty wrote:
On 4/24/19 6:18 PM,
On 4/25/19 4:19 PM, serguei.spit...@oracle.com wrote:
Hi Dan,
Thank you a lot fore reviewing this!
On 4/25/19 12:40, Daniel D. Daugherty wrote:
On 4/24/19 6:18 PM, serguei.spit...@oracle.com wrote:
Please, review fix for:
https://bugs.openjdk.java.net/browse/JDK-8222934
Webrev:
On 4/25/19 4:19 PM, serguei.spit...@oracle.com wrote:
Hi Dan,
Thank you a lot fore reviewing this!
On 4/25/19 12:40, Daniel D. Daugherty wrote:
On 4/24/19 6:18 PM, serguei.spit...@oracle.com wrote:
Please, review fix for:
https://bugs.openjdk.java.net/browse/JDK-8222934
Webrev:
Hi Dan,
Thank you a lot fore reviewing this!
On 4/25/19 12:40, Daniel D. Daugherty wrote:
On
4/24/19 6:18 PM, serguei.spit...@oracle.com wrote:
Please, review fix for:
On 4/24/19 6:18 PM, serguei.spit...@oracle.com wrote:
Please, review fix for:
https://bugs.openjdk.java.net/browse/JDK-8222934
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8222934-jvmti-depr-option.1/
src/hotspot/share/runtime/globals.hpp
No comments.
Hi David,
Looks good.
Thank you for taking care about this!
Thanks,
Serguei
On 4/25/19 01:36, David Holmes wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8222970
vmTestbase/nsk/jdb/eval/eval001/eval001.java is ProblemListed under
JDK-8221503 which is now closed as a duplicate of
Thumbs up!
Dan
On 4/25/19 4:36 AM, David Holmes wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8222970
vmTestbase/nsk/jdb/eval/eval001/eval001.java is ProblemListed under
JDK-8221503 which is now closed as a duplicate of JDK-8212117. So
ProblemList.txt needs updating.
Thanks,
David
Looks OK to me.
On 4/25/19, 4:36 AM, David Holmes wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8222970
vmTestbase/nsk/jdb/eval/eval001/eval001.java is ProblemListed under
JDK-8221503 which is now closed as a duplicate of JDK-8212117. So
ProblemList.txt needs updating.
Thanks,
David
Bug: https://bugs.openjdk.java.net/browse/JDK-8222970
vmTestbase/nsk/jdb/eval/eval001/eval001.java is ProblemListed under
JDK-8221503 which is now closed as a duplicate of JDK-8212117. So
ProblemList.txt needs updating.
Thanks,
David
--
diff -r b43cc3b9ef40
21 matches
Mail list logo
