Re: RFR (S) 8223146 [TESTBUG] new test vmTestbase/nsk/share/ExceptionCheckingJniEnv/exceptionjni001/ fails on Windows

Hi Jc, On 1/05/2019 12:36 pm, Jean Christophe Beyler wrote: Hi David & Serguei, @Serguei: I know from experience that submit-repo builds on various platforms but I'm never sure what tests are actually run. Since this is a testbug for windows, I'm just wondering if we could/should confirm it

RFR (S): 8223177: Data race on JvmtiEnvBase::_tag_map in double-checked locking

Hi all, Can I have reviews for this small change that adds memory fences for double-checked locking? We found this race while working on the Java ThreadSanitizer project. Webrev: https://cr.openjdk.java.net/~manc/8223177/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8223177 -Man

Re: [RFR]8215623: Add incremental dump for jmap histo

Dear Lin, I looked at your CSR and have comments/questions below. > Add the options "chunkcount=" and "maxfilesize=" to JMap -histo to improve JMap's ability Ability to what? The statement above is no complete, it even does not have a dot. Most likely it should have something like:   ...

Re: RFR (S) 8223146 [TESTBUG] new test vmTestbase/nsk/share/ExceptionCheckingJniEnv/exceptionjni001/ fails on Windows

Hi Jc, On 1/05/2019 10:00 am, Jean Christophe Beyler wrote: Hi all, (second day in a row is a "charm"; my apologies for the double post) I figured out the problem for this test bug, I put additional data in the bug itself for tracking. Yep - never use "long" as its size will vary. :)

Re: RFR (S) 8223146 [TESTBUG] new test vmTestbase/nsk/share/ExceptionCheckingJniEnv/exceptionjni001/ fails on Windows

Hi Jc, The fix looks good to me. On 4/30/19 5:00 PM, Jean Christophe Beyler wrote: Hi all, (second day in a row is a "charm"; my apologies for the double post) I figured out the problem for this test bug, I put additional data in the bug itself for tracking. Webrev:

Re: RFR (M) 8223040: Add a AGCT test

Hi Jc, I'd suggest to change the bug title to be:    Add a AsyncGetCallTrace test I'm not sure about the test names. Maybe, it is Okay to keep the AGCT abbreviation. But I'd like to hear other opinions. Thanks, Serguei On 4/30/19 3:47 PM, Jean Christophe Beyler wrote: Hi all, As I start

RFR (M) 8223040: Add a AGCT test

Hi all, As I start looking at working on the AGCT bugs, I wanted to at least start creating a baseline of tests for AGCT. This is an attempt to just have a "base" test (and infrastructure) that tries to call AGCT and get back some sane information. Next step will be to add a few more tests that

Re: RFR (M) 8223044: Add back exception checking in tests

On 4/30/19 3:36 PM, Jean Christophe Beyler wrote: You are right I was overthinking the naming, so I did this now: -    loadedClass = (jclass)

Re: 8222821: com/sun/jdi/ExceptionEvents.java failed

Thank you, Dean, JC, Chris, and Serguei, for reviewing this change! Best regards, Daniil From: Chris Plummer Date: Tuesday, April 30, 2019 at 11:39 AM To: Daniil Titov Subject: Re: FW: 8222821: com/sun/jdi/ExceptionEvents.java failed Looks good. Chris From:

Re: RFR 8223065: Add jcmd to get the listen address of the debugger

On 4/30/19 4:30 AM, Schmelter, Ralf wrote: Hi Chris. I think print_debug_listen_address() should have some exception checking added after the java calls. That is already done by the CHECK_false macro. It checks if an exception is occurred, and returns with false if this is the case. And

Re: RFR (M) 8223044: Add back exception checking in tests

Hi JC, I'm not sure why you are suggesting TRACED_JNI_CALL instead of TRACED_VARARGS. How are they different? Are you suggesting non-varargs calls would just end up using an empty TRACED_JNI_CALL()? Chris On 4/30/19 10:05 AM, Jean

Re: RFR: 8222821: com/sun/jdi/ExceptionEvents.java failed

Hi Daniil, Looks good to me. Thanks, Serguei On 4/25/19 7:37 PM, Jean Christophe Beyler wrote: Hi Daniil, Looks good to me too, (thanks for the detailed explanation about the test failure btw :-)), Jc On Thu, Apr 25, 2019 at 6:43 PM > wrote: Looks good.

Re: RFR (M) 8223044: Add back exception checking in tests

The advantage of the TRACED_VARARGS approach (or leaving it as-is) is that there are limited APIs and callsites affected (only 1 of each in this review, but it's unclear to me if you have more of these changes coming). Chris On 4/29/19 9:49

Re: RFR (XS) 8223152 Put ExceptionCheckingJniEnv in the problem list for Windows

Hi Jc, +vmTestbase/nsk/share/ExceptionCheckingJniEnv/exceptionjni001.java 8223152 windows-all The real issue bug number has to be listed above. So, new issue has to be filed to cover the problem. Then a sub-task of it needs to be created to

RFR (XS) 8223152 Put ExceptionCheckingJniEnv in the problem list for Windows

Hi all, Until I figure out what is going on in the test failure on Windows, here is a small webrev to add it to the problem list: diff -r 7acebe4d65e2 test/hotspot/jtreg/ProblemList.txt --- a/test/hotspot/jtreg/ProblemList.txtThu Apr 18 13:58:31 2019 +0200 +++

Re: RFR 8223065: Add jcmd to get the listen address of the debugger

Hi Ralf, On 30/04/2019 9:33 pm, Schmelter, Ralf wrote: Hi David, good catch. I've moved the vm->native transition back to the start of the method and instead do a native->vm transition before calling print_debug_listen_address() method. webrev:

RE: RFR 8223065: Add jcmd to get the listen address of the debugger

Hi David, good catch. I've moved the vm->native transition back to the start of the method and instead do a native->vm transition before calling print_debug_listen_address() method. webrev: http://cr.openjdk.java.net/~rschmelter/webrevs/8223065/webrev.2/ Best regards, Ralf

RE: RFR 8223065: Add jcmd to get the listen address of the debugger

Hi Chris. > I think print_debug_listen_address() should have some exception checking > added after the java calls. That is already done by the CHECK_false macro. It checks if an exception is occurred, and returns with false if this is the case. And depending on how the dcmd was called, this

Re: RFR(S) 8222935: Add forgotten files for ExceptionCheckingJniEnv

Hi Jc, The new tests are failing on Windows: https://bugs.openjdk.java.net/browse/JDK-8223146 Cheers, David On 25/04/2019 4:07 am, Jean Christophe Beyler wrote: Hi all, When pushing my fix for JDK-8213501, I did not push the added files which were the new test for the whole system. These

Re: RFR 8223065: Add jcmd to get the listen address of the debugger

Responding to Chris's question below ... On 30/04/2019 3:58 am, Chris Plummer wrote: Hi Ralf, I think print_debug_listen_address() should have some exception checking added after the java calls. I'm a little unsure why you modified DebugOnCmdStartDCmd to use print_debug_listen_address(),