Re: 8222422: vmTestbase/nsk/jdi/ClassLoaderReference/definedClasses tests failed with Unexpected Exception: null

2019-05-11 Thread Daniil Titov
Hi David, There are two ways how these reference types (for the classes that become unloaded later) could appear in the collection com.sun.tools.jdi.VirtualMachineImpl maintains and stores in VirtualMachineImpl.typesBySignature instance variable: 1) Initial load when all classes are requested

Re: RFR: 8222422: vmTestbase/nsk/jdi/ClassLoaderReference/definedClasses tests failed with Unexpected Exception: null

2019-05-11 Thread Daniel D. Daugherty
On 5/11/19 6:39 AM, David Holmes wrote: On 11/05/2019 2:14 pm, Jean Christophe Beyler wrote: Isn't that the point? The list returned could have unloaded classes  and we can catch it via this exception (from the comment above the ReferenceType interface):   * Any method on ReferenceType or whi

Re: PING: Re: RFR: JDK-8184770: JDWP support for IPv6

2019-05-11 Thread Chris Hegarty
> On 7 May 2019, at 19:40, serguei.spit...@oracle.com wrote: > > Hi guys, > > We need a couple of partial reviews for this enhancement: > > - From the net-dev to check IPv6-addresses related part. >It does not need to be a thorough review. >We need another pair of eyes to check for o

Re: RFR: 8222422: vmTestbase/nsk/jdi/ClassLoaderReference/definedClasses tests failed with Unexpected Exception: null

2019-05-11 Thread David Holmes
On 11/05/2019 2:14 pm, Jean Christophe Beyler wrote: Isn't that the point? The list returned could have unloaded classes  and we can catch it via this exception (from the comment above the ReferenceType interface):  * Any method on ReferenceType or which directly or indirectly takes  * Ref