RFR: 8225636: SA can't handle prelinked libraries

2019-06-13 Thread Yasumasa Suenaga
Hi all, Please review this change: JBS: https://bugs.openjdk.java.net/browse/JDK-8225636 webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8225636/webrev.00/ I attempted to open the core which is generated by RHEL 6, but it could not . The OS which generated the core is set to enable prelink

Re: RFR JDK-8225474: JDI connector accept fails "Address already in use" with concurrent listeners

2019-06-13 Thread Andrew Leonard
Thanks Alex, good spot. I have done all the changes now with the latest updates, and have performed some stress tests on xLinux, Win64 and Mac64, all successful. Please can I get reviews and sponsor for webrev.04: http://cr.openjdk.java.net/~aleonard/8225474/webrev.04/ Many Thanks Andrew Andrew

Re: 8225543: Jcmd fails to attach to the Java process on Linux using the main class name if whitespace options were used to launch the process

2019-06-13 Thread Daniil Titov
Thank you, David and Serguei, for reviewing this change! Best regards, Daniil On 6/12/19, 10:21 PM, "David Holmes" wrote: Hi Daniil, These changes seem quite reasonable. In hindsight splitting the command-line based on spaces was bound to hit problems with arguments cont

Re: RFR JDK-8225474: JDI connector accept fails "Address already in use" with concurrent listeners

2019-06-13 Thread Alex Menkov
One more minor note for the test: @build HelloWorld JdwpConcurrentAttachTest The test does not use HelloWorld class --alex On 06/12/2019 12:52, serguei.spit...@oracle.com wrote: Hi Andrew, It looks good. Minor comments on the test. There are several places where white spaces are missed aro

Re: RFR JDK-8225474: JDI connector accept fails "Address already in use" with concurrent listeners

2019-06-13 Thread Andrew Leonard
Thanks Serguei, i'll add those changes to my new webrev I am working on based on Alan's suggestions. It should be ready once i've finished my stress tests later today. Cheers Andrew Andrew Leonard Java Runtimes Development IBM Hursley IBM United Kingdom Ltd internet email: andrew_m_leon...@uk.ib