On 13/06/2019 20:18, Andrew Leonard wrote:
Thanks Alex, good spot.
I have done all the changes now with the latest updates, and have
performed some stress tests on xLinux, Win64 and Mac64, all successful.
Please can I get reviews and sponsor for webrev.04:
http://cr.openjdk.java.net/~aleonard/
In doing the recent changes I applied knowledge of how the ConnectorImpl
and its defaultArguments are used to decide on what is necessary from a
threading perspective. I also am only considering the "listening"
concurrency issue, at this stage, and was not considering making all the
jdi classes
Please review this patch, that adjusts SA to reflect removal of extra
header for forwarding pointer.
Bug: https://bugs.openjdk.java.net/browse/JDK-8225801
Webrev: http://cr.openjdk.java.net/~zgu/JDK-8225801/webrev.00/
Test:
hotspot_gc_shenandoah
Manual test.
Thanks,
-Zhengyu
On 6/14/19 5:50 PM, Zhengyu Gu wrote:
> Please review this patch, that adjusts SA to reflect removal of extra header
> for forwarding pointer.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8225801
> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8225801/webrev.00/
Looks good.
This comment is o
On 14/06/2019 15:52, Andrew Leonard wrote:
In doing the recent changes I applied knowledge of how the
ConnectorImpl and its defaultArguments are used to decide on what is
necessary from a threading perspective. I also am only considering the
"listening" concurrency issue, at this stage, and was
Removed the comment and pushed.
Thanks!
-Zhengyu
On 6/14/19 11:55 AM, Aleksey Shipilev wrote:
On 6/14/19 5:50 PM, Zhengyu Gu wrote:
Please review this patch, that adjusts SA to reflect removal of extra header
for forwarding pointer.
Bug: https://bugs.openjdk.java.net/browse/JDK-8225801
Webr
Oops, totally forgot about that. Should this also go into jdk13 as bugfix?
Roman
Am 14. Juni 2019 17:50:57 MESZ schrieb Zhengyu Gu :
>Please review this patch, that adjusts SA to reflect removal of extra
>header for forwarding pointer.
>
>Bug: https://bugs.openjdk.java.net/browse/JDK-8225801
>W
On 6/14/19 12:58 PM, Roman Kennke wrote:
Oops, totally forgot about that. Should this also go into jdk13 as bugfix?
Yes, I think so.
-Zhengyu
Roman
Am 14. Juni 2019 17:50:57 MESZ schrieb Zhengyu Gu :
Please review this patch, that adjusts SA to reflect removal of extra
header f
Hi all,
Please review small fix for "Java Debug Wire Protocol" page.
The change fixes the link and typo ("Inteface" -> "Interface").
jira: https://bugs.openjdk.java.net/browse/JDK-8225682
webrev:
http://cr.openjdk.java.net/~amenkov/docs/jdwp-protocol_jni_link/webrev/
--alex
And the copyright.
Looks good to me.
On 6/14/19, 2:08 PM, Alex Menkov wrote:
Hi all,
Please review small fix for "Java Debug Wire Protocol" page.
The change fixes the link and typo ("Inteface" -> "Interface").
jira: https://bugs.openjdk.java.net/browse/JDK-8225682
webrev:
http://cr.openjdk.j
Please review this patch that removes a method that is no longer needed.
CollectedHeap.oopOffset() was added for Shenandoah GC to offset extra
header for forwarding pointer. Recently, Shenandoah removed the header
and folded the forwarding pointer into regular header, so this method is
now obs
Hi Yasumasa,
It looks good to me.
The function read_exec_segments is already pretty big and needs a
refactoring.
The code you are adding deserves to be a separate function, something
like read_prog_segm...
Thanks,
Serguei
On 6/13/19 22:49, Yasumasa Suenaga wrote:
Hi all,
Please review th
Have you confirmed the link is working?
Chris
On 6/14/19 11:08 AM, Alex Menkov wrote:
Hi all,
Please review small fix for "Java Debug Wire Protocol" page.
The change fixes the link and typo ("Inteface" -> "Interface").
jira: https://bugs.openjdk.java.net/browse/JDK-8225682
webrev:
http://cr.
Hi Yasumasa,
I think you should replace the embedded link with more of a textual
description of where to look in the gdb source.
I'd like to see some short comments. You have a few logical blocks of
code that would greatly benefit from just one line saying what they are
doing, especially the
It works in local build directory, also I checked jdk12 online docs
(https://docs.oracle.com/en/java/javase/12/docs/specs/jdwp/jdwp-protocol.html)
- relative paths preserve.
--alex
On 06/14/2019 11:40, Chris Plummer wrote:
Have you confirmed the link is working?
Chris
On 6/14/19 11:08 AM, A
Thanks Gary,
I'll update copyright year before push
--alex
On 06/14/2019 11:15, Gary Adams wrote:
And the copyright.
Looks good to me.
On 6/14/19, 2:08 PM, Alex Menkov wrote:
Hi all,
Please review small fix for "Java Debug Wire Protocol" page.
The change fixes the link and typo ("Inteface"
Ok. Looks good then.
Chris
On 6/14/19 12:13 PM, Alex Menkov wrote:
It works in local build directory, also I checked jdk12 online docs
(https://docs.oracle.com/en/java/javase/12/docs/specs/jdwp/jdwp-protocol.html)
- relative paths preserve.
--alex
On 06/14/2019 11:40, Chris Plummer wrote:
Hi Alex,
Looks good.
Thanks,
Serguei
On 6/14/19 11:08 AM, Alex Menkov wrote:
Hi all,
Please review small fix for "Java Debug Wire Protocol" page.
The change fixes the link and typo ("Inteface" -> "Interface").
jira: https://bugs.openjdk.java.net/browse/JDK-8225682
webrev:
http://cr.openjdk
I do not see my message below in my serviceability-dev mailbox.
Resending to make sure it reaches the target.
Thanks,
Serguei
On 6/14/19 11:30 AM, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
It looks good to me.
The function read_exec_segments is already pretty big and needs a
refactoring
Hi Yasumasa,
I've added myself as a reviewer, so you can finalize it now.
The fix looks pretty good to me.
One minor suggestion is to use the final field NO_REMOTE instead
of null for initialization of the local variable "remote".
Also just an observation that there is some room for option pro
Please review the change that fixes an intermittent issue.
The problem here is that a bitwise-AND (&) operator was used in the condition
instead of a logical AND operator (&&).
As a result pending_thread->is_thread_fully_suspended() is always evaluated
regardless of the value of at_safepoint va
Hi Daniil,
Great discovery!
The fix looks good to me.
Thanks,
Serguei
On 6/14/19 4:56 PM, Daniil Titov wrote:
Please review the change that fixes an intermittent issue.
The problem here is that a bitwise-AND (&) operator was used in the condition instead
of a logical AND operator (&&).
As a
Hi Serguei,
The discovery was made by David Holmes. Thank you, David, a lot!
Best regards,
Daniil
On 6/14/19, 5:01 PM, "serguei.spit...@oracle.com"
wrote:
Hi Daniil,
Great discovery!
The fix looks good to me.
Thanks,
Serguei
On 6/14/19 4:56 PM,
+1
--alex
On 06/14/2019 17:01, serguei.spit...@oracle.com wrote:
Hi Daniil,
Great discovery!
The fix looks good to me.
Thanks,
Serguei
On 6/14/19 4:56 PM, Daniil Titov wrote:
Please review the change that fixes an intermittent issue.
The problem here is that a bitwise-AND (&) operator was
On 6/14/19 5:06 PM, Daniil Titov wrote:
Hi Serguei,
The discovery was made by David Holmes. Thank you, David, a lot!
Sharp eyes!
Thanks,
Serguei
Best regards,
Daniil
On 6/14/19, 5:01 PM, "serguei.spit...@oracle.com"
wrote:
Hi Daniil,
Great discovery!
The f
On 6/14/19 5:44 PM, Jean Christophe Beyler wrote:
Hi Daniil,
Looks good to me to :-)
FWIW, it seems like:
opto/library_call.cpp: if (!C->too_many_traps(trap_method,
trap_bci, Deoptimization::Reason_intrinsic) &
!C->too_many_traps(trap_method, trap_bci,
Deoptimization::Reason_nu
Hi Serguei,
Thank you for your comment!
On 2019/06/15 8:00, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
I've added myself as a reviewer, so you can finalize it now.
I moved CSR to Finalized, and added a comment for your question.
The fix looks pretty good to me.
One minor suggestion i
Hi Yasumasa,
On 6/14/19 21:11, Yasumasa Suenaga wrote:
Hi Serguei,
Thank you for your comment!
On 2019/06/15 8:00, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
I've added myself as a reviewer, so you can finalize it now.
I moved CSR to Finalized, and added a comment for your question.
28 matches
Mail list logo
