Thanks a lot, David!
Serguei
On 6/28/19 21:44, David Holmes wrote:
Hi Serguei,
Looks good and trivial.
Thanks,
David
On 28/06/2019 9:55 pm, serguei.spit...@oracle.com wrote:
Please, review a fix for:
https://bugs.openjdk.java.net/browse/JDK-8226603
Webrev:
http://cr.openjdk.java.net/~ss
Hi Serguei,
Looks good and trivial.
Thanks,
David
On 28/06/2019 9:55 pm, serguei.spit...@oracle.com wrote:
Please, review a fix for:
https://bugs.openjdk.java.net/browse/JDK-8226603
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8226603-jvmti-a11y.1/
Summary:
The change fix
Hi Daniil,
The definition and use of this hashtable (yet another hashtable
implementation!) will need careful examination. We have to be concerned
about the cost of maintaining it when it may never even be queried. You
would need to look at footprint cost and performance impact.
Unfortunatel
Hi Daniil,
I have several quick comments.
The indent in the hotspot c/c++ files has to be 2, not 4.
https://cr.openjdk.java.net/~dtitov/8185005/webrev.01/src/hotspot/share/runtime/threadSMR.cpp.frames.html
614 JavaThread* ThreadsList::find_JavaThread_from_java_tid(jlong java_tid)
const {
615
Hi Matthias,
The fix is good.
It worked before because both JVMTI_REFERENCE_ARRAY_ELEMENT
and JVMTI_HEAP_REFERENCE_ARRAY_ELEMENT have the same value 3
as Gary noticed.
I'd suggest to fix it in 13 as it is the test fix.
I've added labels 'testbug' and 'noreg-self'.
Thanks,
Serguei
On 6/28/19 12
Please, review a fix for:
https://bugs.openjdk.java.net/browse/JDK-8226603
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8226603-jvmti-a11y.1/
Summary:
The change fixes the a11y issues reported by the Axe tool.
Testing:
Alex checked that the Axe tool reports noting with the
Thanks a lot, Alex!
Serguei
On 6/28/19 3:56 PM, Alex Menkov wrote:
+1
--alex
On 06/28/2019 11:58, gary.ad...@oracle.com wrote:
Looks good to me.
On 6/28/19 2:09 PM, serguei.spit...@oracle.com wrote:
Please, review a test bug fix for:
https://bugs.openjdk.java.net/browse/JDK-8226917
Webrev:
+1
--alex
On 06/28/2019 11:58, gary.ad...@oracle.com wrote:
Looks good to me.
On 6/28/19 2:09 PM, serguei.spit...@oracle.com wrote:
Please, review a test bug fix for:
https://bugs.openjdk.java.net/browse/JDK-8226917
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8226917-mon-events
On 6/28/19 12:33 PM, Daniel D. Daugherty wrote:
On 6/28/19 2:09 PM, serguei.spit...@oracle.com wrote:
Please, review a test bug fix for:
https://bugs.openjdk.java.net/browse/JDK-8226917
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8226917-mon-events-correction2.1/
test/hotspot/
Thank you a lot, Gary!
Serguei
On 6/28/19 11:58 AM, gary.ad...@oracle.com wrote:
Looks good to me.
On 6/28/19 2:09 PM, serguei.spit...@oracle.com wrote:
Please, review a test bug fix for:
https://bugs.openjdk.java.net/browse/JDK-8226917
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/201
Please review the change that improves performance of ThreadMXBean MXBean
methods returning the
information for specific threads. The change introduces the thread table that
uses ConcurrentHashTable
to store one-to-one the mapping between the thread ids and JavaThread objects
and replaces the l
Hi Gary and David, yes it is value 3 in both cases, I noticed that in the jvmti
XML .
Best regards, Matthias
Von meinem iPhone gesendet
> Am 28.06.2019 um 21:17 schrieb "gary.ad...@oracle.com"
> :
>
> I believe you will find in the generate jvmti.h header file
> that both enumerations had as
On 6/28/19 2:09 PM, serguei.spit...@oracle.com wrote:
Please, review a test bug fix for:
https://bugs.openjdk.java.net/browse/JDK-8226917
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8226917-mon-events-correction2.1/
test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/contention/T
Thanks, Serguei.
From: serguei.spit...@oracle.com
Sent: Freitag, 28. Juni 2019 19:28
To: Langer, Christoph ; OpenJDK Serviceability
Subject: Re: RFR CSR (S): 8226940: Adjust permission for delayed starting of
debugging
Hi Christoph,
It looks good, reviewed.
Thanks,
Serguei
On 6/28/19
I believe you will find in the generate jvmti.h header file
that both enumerations had assigned value of 3.
That could explain why a less type strict version of the
compiler would not have complained.
On 6/28/19 3:04 PM, David Holmes wrote:
Hi Matthias,
Dropped build-dev and added serviceabilit
Hi Matthias,
Dropped build-dev and added serviceability-dev as this is a
servicability test.
On 28/06/2019 7:43 am, Baesken, Matthias wrote:
Hello please review this small fix for a compile issue on OSX .
Today I compiled jdk/jdk on a machine with XCode 10.2 . It worked
pretty wel
Looks good to me.
On 6/28/19 2:09 PM, serguei.spit...@oracle.com wrote:
Please, review a test bug fix for:
https://bugs.openjdk.java.net/browse/JDK-8226917
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8226917-mon-events-correction2.1/
Summary:
One more fragment in the native
Please, review a test bug fix for:
https://bugs.openjdk.java.net/browse/JDK-8226917
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8226917-mon-events-correction2.1/
Summary:
One more fragment in the native agent was overlooked and is not
needed anymore
after the fix of JDK-82
I've used CSR instead of RFR in the subject.
So, please, ignore this.
I'll resend it with the correct subject line.
Thanks,
Serguei
On 6/28/19 11:06, serguei.spit...@oracle.com wrote:
Please, review a test bug fix for:
https://bugs.openjdk.java.net/browse/JDK-8226917
Webrev:
http://cr.openj
Please, review a test bug fix for:
https://bugs.openjdk.java.net/browse/JDK-8226917
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8226917-mon-events-correction2.1/
Summary:
One more fragment in the native agent was overlooked and is not
needed anymore
after the fix of JDK-822
Hi Christoph,
It looks good, reviewed.
Thanks,
Serguei
On 6/28/19 03:08, Langer, Christoph wrote:
Hi,
may I please get a
review for the CSR to adjust the permission for delay
Hi,
On Fri, 2019-06-28 at 07:19 -0700, Poonam Parhar wrote:
> Hello,
>
> Thomas Schatzl pointed out that the recalculate_used_stable() call
> in collect_in_background() may not be necessary. Testing the changes
> after removing that call confirmed that. Here's the updated webrev:
> http://cr.open
Hello Severin,
Thanks for catching that. Yes, I meant jstat. I will correct that.
regards,
Poonam
On 6/28/19 9:32 AM, Severin Gehwolf wrote:
Hi Poonam,
One nit caught my eye:
On Fri, 2019-06-21 at 13:30 -0700, Poonam Parhar wrote:
Please review the changes for the fix of:
Bug 8215523: jst
Hi Poonam,
One nit caught my eye:
On Fri, 2019-06-21 at 13:30 -0700, Poonam Parhar wrote:
> Please review the changes for the fix of:
> >
> > Bug 8215523: jstat reports incorrect values for OU for CMS GC
> > Webrev: http://cr.openjdk.java.net/~poonam/8215523/webrev.00/
http://cr.openjdk.java.ne
Hello,
Thomas Schatzl pointed out that the recalculate_used_stable() call in
collect_in_background() may not be necessary. Testing the changes after
removing that call confirmed that. Here's the updated webrev:
http://cr.openjdk.java.net/~poonam/8215523/webrev.01/
Thanks,
Poonam
On 6/21/19 5
Hi,
may I please get a review for the CSR to adjust the permission for delayed
starting of debugging.
The change itself has been reviewed already but a CSR had not been created yet.
We were waiting for approval of CSR JDK-8223456 about the overall "delayed
starting of debugging" feature. This
26 matches
Mail list logo
