Hello, thanks for the review !
> I'd suggest to fix it in 13 as it is the test fix.
I'll push it then to 13 , fine with me !
Best regards, Matthias
>
> Hi Matthias,
>
> The fix is good.
> It worked before because both JVMTI_REFERENCE_ARRAY_ELEMENT
> and JVMTI_HEAP_REFERENCE_ARRAY_ELEMENT ha
Hi,
Please review a fix that potentially handle NPE and allow heap to dump from a
process were we get source file name as null.
Background:
For taking heap dump of JShell process, we get getSourceFileName() as null.
Current implementation doesn't have null check.
This fix will handle the null
Hi Gil,
I would support an improvement in sampling as there is an obvious bias which
allows me to write benchmarks where JFR completely misses things it should
find. That said, I’m not sure that waking a thread up every 10ms is a great
idea as it is very disruptive to Linux thread scheduling. I
Hi Gil,
Redirecting to the hotspot-jfr-dev alias.
Cheers,
David
On 30/06/2019 5:20 pm, Gil Tene wrote:
I would like to discuss a potential improvement to the JFR thread
sampling mechanism, and would like to see if the change we'd
propose has already been considered in the past.
I believe that
I would like to discuss a potential improvement to the JFR thread
sampling mechanism, and would like to see if the change we'd
propose has already been considered in the past.
I believe that the current thread sampling mechanism (mostly via
hotspot/share/jfr/periodic/sampling/jfrThreadSampler.cpp)
