On 01/07/2019 20:41, Andrew Leonard wrote:
Any one able to review please?
This one will take a significant time to review. We also need to figure
out if an @implNote if needed as nobody using these connectors will know
(from the javadoc) that some of the implementations are thread safe. I
hope
Hi Chris,
Thanks for the review.
Thanks,
Fairoz
> -Original Message-
> From: Chris Plummer
> Sent: Monday, July 01, 2019 11:21 PM
> To: Fairoz Matte ; serviceability-
> d...@openjdk.java.net
> Subject: Re: RFR: 8225715: jhsdb jmap fails to write binary heap dump of a
> jshell process
>
Hi David,
On 7/1/19 19:03, David Holmes wrote:
Hi Serguei,
The updates to the heading levels all looks fine.
Okay, thanks!
However the tables in the generated output look broken - they all have
empty "header" rows with incorrect columns and no text. ??
I'm not sure about this.
What ex
Hi Serguei,
The updates to the heading levels all looks fine.
However the tables in the generated output look broken - they all have
empty "header" rows with incorrect columns and no text. ??
David
On 2/07/2019 11:08 am, serguei.spit...@oracle.com wrote:
Hi David,
On 7/1/19 14:15, David H
Hi Alex,
Thank you for the review!
Could also look at the webrev v2? :
http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8226596-jdwp-a11y.2/
This change also updates page headings (result of our discussion with
David H.).
Thanks,
Serguei
On 7/1/19 18:02, Alex Menkov wrote:
LGTM
--alex
O
Hi David,
On 7/1/19 14:15, David Holmes wrote:
Hi Serguei,
On 2/07/2019 4:57 am, serguei.spit...@oracle.com wrote:
Please, review a doc issue fix for:
https://bugs.openjdk.java.net/browse/JDK-8226596
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8226596-jdwp-a11y.1/
The updated
LGTM
--alex
On 07/01/2019 14:15, David Holmes wrote:
Hi Serguei,
On 2/07/2019 4:57 am, serguei.spit...@oracle.com wrote:
Please, review a doc issue fix for:
https://bugs.openjdk.java.net/browse/JDK-8226596
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8226596-jdwp-a11y.1/
The up
PING: Could you review it?
http://cr.openjdk.java.net/~ysuenaga/JDK-8209790/webrev.03/
Yasumasa
On 2019/06/25 16:47, Yasumasa Suenaga wrote:
Hi,
This enhancement has been retargeted to 14, and the CSR has been approved.
I uploaded a webrev for 14. Could you review it?
http://cr.ope
Hi Serguei,
On 2/07/2019 4:57 am, serguei.spit...@oracle.com wrote:
Please, review a doc issue fix for:
https://bugs.openjdk.java.net/browse/JDK-8226596
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8226596-jdwp-a11y.1/
The updated JDWP protocol page:
http://cr.openjdk.java.net/~ss
Any one able to review please?
Thanks
Andrew
Andrew Leonard
Java Runtimes Development
IBM Hursley
IBM United Kingdom Ltd
internet email: andrew_m_leon...@uk.ibm.com
From: Andrew Leonard/UK/IBM
To: Alan Bateman
Cc: serviceability-dev@openjdk.java.net
Date: 19/06/2019 18:29
Subject
Please, review a doc issue fix for:
https://bugs.openjdk.java.net/browse/JDK-8226596
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8226596-jdwp-a11y.1/
The updated JDWP protocol page:
http://cr.openjdk.java.net/~ss
Thanks a lot, Alex!
Serguei
On 7/1/19 11:25, Alex Menkov wrote:
+1
--alex
On 06/28/2019 21:44, David Holmes wrote:
Hi Serguei,
Looks good and trivial.
Thanks,
David
On 28/06/2019 9:55 pm, serguei.spit...@oracle.com wrote:
Please, review a fix for:
https://bugs.openjdk.java.net/browse/
+1
--alex
On 06/28/2019 21:44, David Holmes wrote:
Hi Serguei,
Looks good and trivial.
Thanks,
David
On 28/06/2019 9:55 pm, serguei.spit...@oracle.com wrote:
Please, review a fix for:
https://bugs.openjdk.java.net/browse/JDK-8226603
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2
Looks good.
Chris
On 6/30/19 9:31 PM, Fairoz Matte wrote:
Hi,
Please review a fix that potentially handle NPE and allow heap to dump from a
process were we get source file name as null.
Background:
For taking heap dump of JShell process, we get getSourceFileName() as null.
Current implementat
14 matches
Mail list logo
