Re: RFR (L) 8228998: Remove the testing against NSK_FALSE from tests

Looks good. Chris On 8/1/19 6:55 PM, Jean Christophe Beyler wrote: Hi Serguei, Thanks :) Done, I updated it and the copyrights and did an in place replacement:

Re: RFR (L) 8228998: Remove the testing against NSK_FALSE from tests

Hi Serguei, Thanks :) Done, I updated it and the copyrights and did an in place replacement: Webrev: http://cr.openjdk.java.net/~jcbeyler/8228998/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8228998 Thanks again, Jc On Thu, Aug 1, 2019 at 5:27 PM wrote: > Hi Jc, > > Looks good. >

Re: RFR (L) 8228998: Remove the testing against NSK_FALSE from tests

Hi Jc, Looks good. This still aligned incorrectly: 221 static bool getFieldsAndObjects(jvmtiEnv* jvmti, 222 JNIEnv* jni, 223 jclass debugeeClass, 224 jclass rootObjectClass, 225 jclass chainObjectClass, 226 jobject* rootObjectPtr, 227 jfieldID* reachableChainField, 228 jfieldID* unreachableChai

Re: RFR (L) 8228998: Remove the testing against NSK_FALSE from tests

Hi Jc, Thank you for taking care about this! Most of the links in the webrev can not be resolved. I'm getting the error: "403 - Forbidden". The only item that works is: |Cdiffs

Re: RFR(T): 8228999 ProblemList vmTestbase/nsk/jvmti/GetThreadState/thrstat001/TestDescription.java

Thanks for the review. Can't list you as a reviewer since I already pushed the changeset... Dan On 8/1/19 5:35 PM, serguei.spit...@oracle.com wrote: Hi Dan, +1 Thank you or taking care about it! Serguei On 8/1/19 1:04 PM, Chris Plummer wrote: Looks good. Chris On 8/1/19 12:28 PM, Daniel

Re: RFR(T): 8228999 ProblemList vmTestbase/nsk/jvmti/GetThreadState/thrstat001/TestDescription.java

Hi Dan, +1 Thank you or taking care about it! Serguei On 8/1/19 1:04 PM, Chris Plummer wrote: Looks good. Chris On 8/1/19 12:28 PM, Daniel D. Daugherty wrote: Greetings, There are almost 70 sightings of this test failure in the CI. Almost all of the are on Windows so time to ProblemList th

Re: RFR(T): 8228999 ProblemList vmTestbase/nsk/jvmti/GetThreadState/thrstat001/TestDescription.java

Thanks for the fast review! Dan On 8/1/19 4:04 PM, Chris Plummer wrote: Looks good. Chris On 8/1/19 12:28 PM, Daniel D. Daugherty wrote: Greetings, There are almost 70 sightings of this test failure in the CI. Almost all of the are on Windows so time to ProblemList this test... $ hg diff

Re: RFR(T): 8228999 ProblemList vmTestbase/nsk/jvmti/GetThreadState/thrstat001/TestDescription.java

Looks good. Chris On 8/1/19 12:28 PM, Daniel D. Daugherty wrote: Greetings, There are almost 70 sightings of this test failure in the CI. Almost all of the are on Windows so time to ProblemList this test... $ hg diff diff -r 9afbcd27f26f test/hotspot/jtreg/ProblemList.txt --- a/test/hotspot/j

RFR(T): 8228999 ProblemList vmTestbase/nsk/jvmti/GetThreadState/thrstat001/TestDescription.java

Greetings, There are almost 70 sightings of this test failure in the CI. Almost all of the are on Windows so time to ProblemList this test... $ hg diff diff -r 9afbcd27f26f test/hotspot/jtreg/ProblemList.txt --- a/test/hotspot/jtreg/ProblemList.txt Thu Aug 01 09:29:13 2019 -0700 +++ b/test/hotsp

Re: RFR: [XS] 8228658: test GetTotalSafepointTime.java fails on fast Linux machines with Total safepoint time 0 ms

On 1/08/2019 5:13 pm, Baesken, Matthias wrote: Hi David + JC , thanks for the reviews . David - I added the suggested print-outputs , and also the parameter to executeThreadDumps . Okay - thanks for that. David - Best regards, Matthias -Original Message- From: David Hol

RE: RFR: [XS] 8228658: test GetTotalSafepointTime.java fails on fast Linux machines with Total safepoint time 0 ms

Hi David + JC , thanks for the reviews . David - I added the suggested print-outputs , and also the parameter to executeThreadDumps . Best regards, Matthias > -Original Message- > From: David Holmes > Sent: Mittwoch, 31. Juli 2019 23:57 > To: Baesken, Matthias ; Jean Christophe >