Re: RFR: 8170299: Debugger does not stop inside the low memory notifications code

On 7/31/19 11:50 PM, David Holmes wrote: Hi Daniil, On 25/07/2019 3:34 am, Daniil Titov wrote: Hi David, Hope you had a great vacation! I did thank you. Apologies again for taking so long to get back to this work. Please find below the latest version of the change . The only difference f

RFR (M) 8229036: Remove the testing against NSK_TRUE from tests

Hi all, Here is the webrev that does the removal of if (.* == NSK_TRUE) and replaces them with if (.*). Webrev: http://cr.openjdk.java.net/~jcbeyler/8229036/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8229036 This was tested by running the tests changed on my dev machine, I'll push

Re: RFR (M) 8229036: Remove the testing against NSK_TRUE from tests

Hi JC, Why does this webrev also remove references NSK_FALSE, and the previous one references to NSK_TRUE? thanks, Chris On 8/2/19 2:21 PM, Jean Christophe Beyler wrote: Hi all, Her

Re: RFR (M) 8229036: Remove the testing against NSK_TRUE from tests

Hi Chris, I only did it when there were repercussions to the change of if (.* == NSK_TRUE). For example: http://cr.openjdk.java.net/~jcbeyler/8229036/webrev.00/test/hotspot/jtreg/vmTestbase/nsk/jvmti/GetTime/gettime001/gettime001.cpp.udiff.html I wanted to move: -if (success != NSK_TRUE) {

Re: RFR: 8185005: Improve performance of ThreadMXBean.getThreadInfo(long ids[], int maxDepth)

Hi David, Thank you for your detailed review. Please review a new version of the fix that includes the changes you suggested: - ThreadTableCreate_lock scope is reduced to cover the creation of the table only; - ThreadTableCreate_lock is made _safepoint_check_always; - ServiceThread is no longer

Re: RFR (M) 8229036: Remove the testing against NSK_TRUE from tests

Ok. I think the changes are fine as is. thanks, Chris On 8/2/19 3:00 PM, Jean Christophe Beyler wrote: Hi Chris, I only did it when there were repercussions to the change of if (.* == NSK_TR