Re: RFR: 8185005: Improve performance of ThreadMXBean.getThreadInfo(long ids[], int maxDepth)

2019-08-07 Thread Robbin Ehn
Hi Daniil, On 8/3/19 12:16 AM, Daniil Titov wrote: The is_dead parameter still bothers me here. I can't make enough sense out of the template code in ConcurrentHashtable to see why we have to have it, but I'm concerned that its very existence means we perhaps should not be trying to extend CHT i

RFR: 8195600: [Graal] jdi tests timeouts with Graal because debuggee vm is not resumed

2019-08-07 Thread Daniil Titov
Please review the change that fixes the failing tests when running with Graal. The issue originally included several vmTestbase/nsk/jdi tests but only 2 of them still fail: - vmTestbase/nsk/jdi/VirtualMachine/instanceCounts/instancecounts003/instancecounts003.java - vmTestbase/nsk/jdi/ObjectRef

Re: RFR(S): 8228960: [TESTBUG] containers/docker/TestJcmdWithSideCar.java: jcmd reports main class as 'Unknown'

2019-08-07 Thread David Holmes
On 8/08/2019 9:04 am, Mikhailo Seledtsov wrote: Hi Severin, Bob,   Thank you for reviewing the code. On 8/7/19, 11:38 AM, Bob Vandette wrote: Can’t you come up with a better way of synchronizing the test by possibly writing a file and waiting for it to exist with a timeout? I will try out t

RFR(S): 8227645: Some tests in serviceability/sa run with fixed -Xmx values and risk running out of memory​

2019-08-07 Thread Chris Plummer
Hello, Please review the following: http://cr.openjdk.java.net/~cjplummer/8227645/webrev.00/webrev.open/ https://bugs.openjdk.java.net/browse/JDK-8227645 I moved the offending tests to their own directory and added "exclusiveAccess.dirs=." for that directory. There were two extra support clas