Actually looking at JDK-8207267 a little closer, it looks like it's job
is to re-enable tests that have been disabled with @requires
!vm.graal.enabled, so it looks like we have two different approaches
going in here. Which is preferred? If the preference is to problem list,
do we want to undo
That sounds like a better approach to me.
thanks,
Chris
On 8/8/19 4:33 PM, dean.l...@oracle.com wrote:
This is the kind of failure that is expected to go away with libgraal.
You can add the tests to the Graal-specific problem list (see
JDK-8196611) and they should be re-enabled with
This is the kind of failure that is expected to go away with libgraal.
You can add the tests to the Graal-specific problem list (see
JDK-8196611) and they should be re-enabled with libgraal (see
JDK-JDK-8207267).
dl
On 8/8/19 10:21 AM, Chris Plummer wrote:
Hi Daniil,
My only objection is
Hi Daniil,
My only objection is at some point it seems we need to be able to run
these tests with graal (and other tests that have been disabled due to
graal) because graal might be the only compiler, and we'll lose test
coverage without these tests. Currently we have 260 jtreg tests disabled
Hi Chris,
The change looks good to me.
Thanks,
Daniil
On 8/7/19, 6:57 PM, "serviceability-dev on behalf of Chris Plummer"
wrote:
Hello,
Please review the following:
http://cr.openjdk.java.net/~cjplummer/8227645/webrev.00/webrev.open/
Hi Daniil,
Looks good to me,
Jc
On Wed, Aug 7, 2019 at 3:39 PM Daniil Titov
wrote:
> Please review the change that fixes the failing tests when running with
> Graal. The issue originally
> included several vmTestbase/nsk/jdi tests but only 2 of them still fail:
> -
>
On 8/8/19 11:16 AM, Andrew Dinn wrote:
> I'm not 100% clear what the point of this test is but it looks like it
> is meant to exercise the stack backtrace code when there is a compiled
> method on the stack. If so then I guess your hack fits the bill while
> removing the -Xcomp flag from the
Hi Nick,
On 08/08/2019 10:32, Nick Gasson wrote:
> Bug: https://bugs.openjdk.java.net/browse/JDK-8229118
> Webrev: http://cr.openjdk.java.net/~ngasson/8229118/webrev.0/
>
> This test starts a sub-process with -Xcomp and then uses the SA to get a
> stack trace of it. It expects to see this line:
Hi,
Bug: https://bugs.openjdk.java.net/browse/JDK-8229118
Webrev: http://cr.openjdk.java.net/~ngasson/8229118/webrev.0/
This test starts a sub-process with -Xcomp and then uses the SA to get a
stack trace of it. It expects to see this line:
In code in NMethod for
