Re: RFC: 8229160: Reimplement JvmtiRawMonitor to use PlatformMonitor

2019-08-18 Thread serguei.spit...@oracle.com
Hi David, Just wanted to tell you that I'm looking at this but need more time. Thanks, Serguei On 8/14/19 23:22, David Holmes wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8229160 Preliminary webrev (still has rough edges): http://cr.openjdk.java.net/~dholmes/8229160/webrev.prelim/

Re: RFR: JDK-8228547: accessibility errors in jvmti.html

2019-08-18 Thread serguei.spit...@oracle.com
Hi Alex, It looks great to me. I looked through the old and new documents in sync and did not find any problems. The webrev itself looks good too. Very nice job! I realize it was not easy as many spots in the jvmti.xsl needed an update. It is a big deal to get rid of these accessibility errors

Re: PING: RFR: 8226204: SA: Refactoring for option processing in SALauncher

2019-08-18 Thread serguei.spit...@oracle.com
Hi Yasumasa, Thank you for the update! The typo below still is not fixed (replace: "be map" => "be mapped"): 225 * You also can set the options which cannot be map to old fashioned 242 * SAGetopt parses and validat