Bug: https://bugs.openjdk.java.net/browse/JDK-8227563
webrev: http://cr.openjdk.java.net/~dholmes/8227563/webrev/
See bug report for gory details. Basically on Windows thread-cpu-time
may only get updated at the resolution of the timer interrupt, which may
be as long as 16ms. The test checks th
Hi Alex,
The fix looks good.
Good simplification!
Thanks,
Serguei
On 9/4/19 12:19, Alex Menkov wrote:
Hi all,
Please review the fix for BadHandshakeTest test.
The problem is the test connects to the server twice and if debuggee
hasn't yet handled disconnection, the next connect gets "connec
Hi Matthias,
It looks good in general but I have some minor comments below.
http://cr.openjdk.java.net/~mbaesken/webrevs/8230466.1/src/jdk.hotspot.agent/linux/native/libsaproc/symtab.c.frames.html
279 build_id_to_debug_filename (size_t size, unsigned char *data)
280 {
. . .
283 filename
Hi all,
Please review the fix for BadHandshakeTest test.
The problem is the test connects to the server twice and if debuggee
hasn't yet handled disconnection, the next connect gets "connection
refused" error.
Instead of adding delay before 2nd connect (we never know "good" value
for the delay
Looks good!
Yasumasa (ysuenaga)
On 2019/09/04 16:28, Baesken, Matthias wrote:
Hello Yasumasa and Chris, thanks for your input .
Here is a new webrev , without the unneeded memset-calls after calloc .
http://cr.openjdk.java.net/~mbaesken/webrevs/8230466.1/
Hope everyone is happy with th
Hello Yasumasa and Chris, thanks for your input .
Here is a new webrev , without the unneeded memset-calls after calloc .
http://cr.openjdk.java.net/~mbaesken/webrevs/8230466.1/
Hope everyone is happy with this now 😉 !
Best regards, Matthias
> Hi Matthias,
>
> src/jdk.hotspot.agent/linu
