Re: RFR(XS) 8230674 Heap dumps should exclude dormant CDS archived objects of unloaded classes

2019-09-09 Thread Ioi Lam
On 9/6/19 4:06 PM, Jiangli Zhou wrote: On Fri, Sep 6, 2019 at 3:17 PM Ioi Lam wrote: On 9/6/19 11:48 AM, Jiangli Zhou wrote: On Fri, Sep 6, 2019 at 9:43 AM Ioi Lam wrote: On 9/5/19 11:11 PM, David Holmes wrote: On 6/09/2019 1:39 pm, Ioi Lam wrote: On 9/5/19 8:18 PM, David Holmes wrote:

Re: RFR 8230303 : JDB hangs when running monitor command

2019-09-09 Thread Ivan Gerasimov
Thank you Serguei for review! On 9/9/19 9:14 PM, serguei.spit...@oracle.com wrote: Hi Ivan, Thank you for filing the shadow bug and fixing this issue! I've targeted the bug to 14 (please, fix me if it is wrong). Yes, this is correct, thanks. The fix looks good to me. Do you have any plans

Re: RFR 8230303 : JDB hangs when running monitor command

2019-09-09 Thread serguei.spit...@oracle.com
Hi Ivan, Thank you for filing the shadow bug and fixing this issue! I've targeted the bug to 14 (please, fix me if it is wrong). The fix looks good to me. Do you have any plans to backport it to the earlier releases? Thanks, Serguei On 9/9/19 20:41, Ivan Gerasimov wrote: Hello! jdb utility

RFR 8230303 : JDB hangs when running monitor command

2019-09-09 Thread Ivan Gerasimov
Hello! jdb utility has a command 'monitor ', which allows to execute the specified command every time the debuggee stops. If the modifies the list of installed monitors (the simplest example is 'monitor unmonitor 1'), then jdb hits a ConcurrentModificationException, and hangs the debuggee.

Re: RFC: 8229160: Reimplement JvmtiRawMonitor to use PlatformMonitor

2019-09-09 Thread serguei.spit...@oracle.com
Hi David, On 9/9/19 15:49, David Holmes wrote: Hi Serguei, . . . The JDWP implementation is using RawMonitor's. Please, see functions debugMonitorWait()/debugMonitorTimedWait() in src/jdk.jdwp.agent/share/native/libjdwp/util.c. It expects the JVMTI_ERROR_INTERRUPT but never makes a call t

Re: RFC: 8229160: Reimplement JvmtiRawMonitor to use PlatformMonitor

2019-09-09 Thread David Holmes
Hi Serguei, On 10/09/2019 4:26 am, serguei.spit...@oracle.com wrote: Hi David, On 9/8/19 19:15, David Holmes wrote: Hi Dan, On 7/09/2019 6:50 am, Daniel D. Daugherty wrote: Hi David, I've finally gotten back to this email thread... Thanks. FYI testing to date:  - tiers 1 -3 all platform

Re: RFC: 8229160: Reimplement JvmtiRawMonitor to use PlatformMonitor

2019-09-09 Thread serguei.spit...@oracle.com
Hi David, On 9/8/19 19:15, David Holmes wrote: Hi Dan, On 7/09/2019 6:50 am, Daniel D. Daugherty wrote: Hi David, I've finally gotten back to this email thread... Thanks.

Re: RFR: 8229378: jdwp library loader in linker_md.c quietly truncates on buffer overflow

2019-09-09 Thread Adam Farley8
Hi Serguei, Apologies for the delay. The errors have all been fixed, and the requested tests mostly passed, windows and linux. No test group had more failures post-fix than pre-fix, so I'm calling that a win. The new webrev can be found here: http://cr.openjdk.java.net/~afarley/8229378.2/web

Re: RFC: 8229160: Reimplement JvmtiRawMonitor to use PlatformMonitor

2019-09-09 Thread Daniel D. Daugherty
On 9/8/19 10:15 PM, David Holmes wrote: Hi Dan, On 7/09/2019 6:50 am, Daniel D. Daugherty wrote: Hi David, I've finally gotten back to this email thread... Thanks. FYI testing to date:  - tiers 1 -3 all platforms  - hotspot: serviceability/jvmti   /jdwp    

RE: RFR: JDK-8192057: com/sun/jdi/BadHandshakeTest.java fails with java.net.ConnectException

2019-09-09 Thread Reingruber, Richard
Hi Alex, > Of course error can be cleared before each try - there is not functional > difference. It is just a little confusing, as you can get an exception in L. 95, too. But I'm ok with it, if you prefer it like this. I would suggest, though, to sleep some ms before a retry and double th