Looks good Leonid!
Thanks,
David
On 27/09/2019 4:28 pm, Leonid Mesnik wrote:
Thanks for feedback.
I checked time execution. Tests takes several seconds longer on the
hosts which compress cores. Also, tests
TestJmapCore.java, TestJmapCoreMetaspace.java are slow and not included
in tier1_serv
Thanks Serguei!
/Per
On 9/27/19 12:20 AM, serguei.spit...@oracle.com wrote:
Hi Per,
It looks good and trivial.
Thanks,
Serguei
On 9/26/19 1:39 PM, Per Liden wrote:
Please review this one-liner to disable
vmTestbase/nsk/jvmti/Allocate/alloc001 when using ZGC. The root
problem is that ZGC do
Hi Leonid,
Looks good in general.
http://cr.openjdk.java.net/~lmesnik/8230942/webrev.01/test/lib/jdk/test/lib/SA/SATestUtils.java.udiff.html
Minor:
+import java.io.File;
import java.io.IOException;
-import java.util.List;
+import java.io.Fil
Hi,
Could I please get reviews for this SA fix? The issue only happens
intermittently and with -Xcomp. The new regression test reproduces the
issue somewhat reliably. I got 10/10 fails for unpatched, but I've seen
it pass as well.
When the issue happens, PCDesc's getScopeDecodeOffset() returs 0
(
On 9/27/19 2:16 AM, Per Liden wrote:
Hi Igor,
On 9/27/19 3:49 AM, Igor Ignatev wrote:
Hi Per,
On Sep 26, 2019, at 2:32 PM, Per Liden wrote:
Hi Igor,
I don't think it belongs in the problem list, for two reasons:
1) The test doesn't fail because of a bug. It fails because ZGC
doesn't cur
Hi Dan,
The background here is that ZGC previously (by design) required a
certain amount of address space to run. So it was a deliberate decision
to not support RLIMIT_AS. However, as ZGC's design have progressed,
we're now in a position where we could reconsider this (which is why the
RFE wa
Thanks for the background info. I think that's a more convincing
explanation and I'm okay with the change as is.
Please add a comment to JDK-8231552 making it clear that
vmTestbase/nsk/jvmti/Allocate/alloc001 should be reenabled
if/when the bug^H^H^H RFE is fixed. :-)
Dan
On 9/27/19 9:39 AM, P
Hi Daniil,
Just notice I did not reply to you.
Thank you for the explanation!
Have you already pushed this one?
Thanks,
Serguei
On 9/24/19 12:46, Daniil Titov wrote:
Hi Serguei,
Thank you for reviewing this version of the fix.
Just one question about ThreadIdTable::remove_thread(jlong
Hi Serguei,
Yes, it is already pushed in the repository [1].
[1] https://hg.openjdk.java.net/jdk/jdk/rev/f4abe950c3b0
Best regards,
Daniil
On 9/27/19, 10:58 AM, "serguei.spit...@oracle.com"
wrote:
Hi Daniil,
Just notice I did not reply to you.
Thank you for the explanation
On 9/27/19 11:06, Daniel D. Daugherty wrote:
On 9/27/19 1:58 PM, serguei.spit...@oracle.com wrote:
Hi Daniil,
Just notice I did not reply to you.
Thank you for the explanation!
Have you already pushed this one?
Pushed on 2019.09.25 at 1416 ET. It has made it thru Tier7 testing
as of yesterda
On 9/27/19 1:58 PM, serguei.spit...@oracle.com wrote:
Hi Daniil,
Just notice I did not reply to you.
Thank you for the explanation!
Have you already pushed this one?
Pushed on 2019.09.25 at 1416 ET. It has made it thru Tier7 testing
as of yesterday...
Dan
Thanks,
Serguei
On 9/24/19 12:
On Mon, Sep 23, 2019 at 11:08 PM David Holmes
wrote:
> Except when I run it through our test system ReservedStackTest is still
> failing :(
>
> I tested it initially when Fred proposed it and that went fine. It also
> passes for me locally on Linux.
>
I committed the changes other than for @Rese
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8231287
http://cr.openjdk.java.net/~cjplummer/8231287/webrev.00
Basically no longer have jmap consume and hide exceptions that are
thrown, and have all tools catch and print any exception that is
propagated to Tools.
Hi Chris,
It looks good.
Thanks,
Serguei
On 9/27/19 1:29 PM, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8231287
http://cr.openjdk.java.net/~cjplummer/8231287/webrev.00
Basically no longer have jmap consume and hide exceptions that are
+1.
Paul
On 9/27/19, 2:06 PM, "serviceability-dev on behalf of
serguei.spit...@oracle.com" wrote:
Hi Chris,
It looks good.
Thanks,
Serguei
On 9/27/19 1:29 PM, Chris Plummer wrote:
> Hello,
>
> Please review the following:
>
> https://bugs
Thanks for the quick reviews!
Chris
On 9/27/19 2:49 PM, Hohensee, Paul wrote:
+1.
Paul
On 9/27/19, 2:06 PM, "serviceability-dev on behalf of serguei.spit...@oracle.com"
wrote:
Hi Chris,
It looks good.
Thanks,
Serguei
On 9/27/19 1:29 PM, Chris P
Please, review fix for test enhancement:
https://bugs.openjdk.java.net/browse/JDK-8231595
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8231595-jvmti-susp-tlist.1/
Summary:
New test is a coverage for the JVMTI bug:
https://bugs.openjdk.java.net/browse/JDK-8217762
Suspen
17 matches
Mail list logo
