Hi Coleen,
Sorry rather long-winded reply ...
On 1/10/2019 11:52 pm, coleen.phillim...@oracle.com wrote:
Summary: Remove RedefineClasses adjustment and test, but improve
checking for method/class matching.
Tested with tier1 with -Xcheck:jni locally, and tier1 on Oracle platforms.
open
Hi Daniil,
Thanks again for your perseverance with this one.
This looks fine to me.
Thanks,
David
-
On 2/10/2019 6:57 am, Daniil Titov wrote:
Hello,
Please review a new version of the change [1] that fixes the problem with the
debugger not stopping in the low memory notification
Looks good.
Thanks,
David
On 2/10/2019 9:57 am, serguei.spit...@oracle.com wrote:
Hi David,
Yes, this is another place to fix the same typo, thanks.
It has to be results[i] instead of err.
I'll update the webrev in place.
Thanks,
Serguei
On 10/1/19 4:00 PM, David Holmes wrote:
Hi Serguei,
On 2/10/2019 9:27 am, coleen.phillim...@oracle.com wrote:
On 10/1/19 6:21 PM, David Holmes wrote:
Hi Coleen,
Thanks for taking a look.
On 2/10/2019 7:04 am, coleen.phillim...@oracle.com wrote:
Hi David,
Yes, this is another place to fix the same typo, thanks.
It has to be results[i] instead of err.
I'll update the webrev in place.
Thanks,
Serguei
On 10/1/19 4:00 PM, David Holmes wrote:
Hi Serguei,
Shouldn't this:
80 for (int i = 0; i < threadsCount; i++) {
81 LOG("
On 10/1/19 6:21 PM, David Holmes wrote:
Hi Coleen,
Thanks for taking a look.
On 2/10/2019 7:04 am, coleen.phillim...@oracle.com wrote:
http://cr.openjdk.java.net/~dholmes/8231289/webrev/src/hotspot/share/prims/jvmtiEnv.cpp.frames.html
I think it's odd that PROPER_TRANSITIONS looked
Hi Serguei,
Shouldn't this:
80 for (int i = 0; i < threadsCount; i++) {
81 LOG(" thread #%d: (%d)", i, (int)results[i]);
82 check_jvmti_status(jni, err, "suspendTestedThreads: error in
SuspendThreadList");
also be testing results[i] rather than err? Or do you need to test err
Alex, Chris and David,
The updated webrev is:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8231595-jvmti-susp-tlist.3/
This version changes are:
- the "first" and "last" are passed to the test to set the suspenderIndex
- fixed typo at line 120
- the ThreadToSuspend.run() loop is
Hi Coleen,
Thanks for taking a look.
On 2/10/2019 7:04 am, coleen.phillim...@oracle.com wrote:
http://cr.openjdk.java.net/~dholmes/8231289/webrev/src/hotspot/share/prims/jvmtiEnv.cpp.frames.html
I think it's odd that PROPER_TRANSITIONS looked like the right thing to
do, but we always took
Serguei, thank you for the code review!
Coleen
On 10/1/19 5:46 PM, serguei.spit...@oracle.com wrote:
Hi Coleen,
The fix looks good to me.
Thank you for taking care about the test!
Thanks,
Serguei
On 10/1/19 6:52 AM, coleen.phillim...@oracle.com wrote:
Summary: Remove RedefineClasses
Hi Coleen,
The fix looks good to me.
Thank you for taking care about the test!
Thanks,
Serguei
On 10/1/19 6:52 AM, coleen.phillim...@oracle.com wrote:
Summary: Remove RedefineClasses adjustment and test, but improve
checking for method/class matching.
Tested with tier1 with -Xcheck:jni
Hi Alex,
On 10/1/19 12:23 PM, Alex Menkov wrote:
Hi Serguei,
Looks good.
The only note:
(libSuspendWithCurrentThread.cpp)
115 check_jvmti_status(jni, err, "resumeTestedThreads: error in
ResumeThreadList");
This check in a cycle looks useless.
Nice catch, thanks!
The
Hi Chris,
On 10/1/19 12:46 PM, Chris Plummer wrote:
Hi Serguei,
If someone changes THREADS_COUNT, then SuspenderIndex would no longer
do what we want. I suggest passing in something like "first" and "last".
Okay, I'll update it this way.
120 * - main thread registers tested threads
http://cr.openjdk.java.net/~dholmes/8231289/webrev/src/hotspot/share/prims/jvmtiEnv.cpp.frames.html
I think it's odd that PROPER_TRANSITIONS looked like the right thing to
do, but we always took the alternate path with the large comment about
why it is evil. Can we have an RFE to move this
Hello,
Please review a new version of the change [1] that fixes the problem with the
debugger not stopping in the low memory notification code. The fix moves the
send notifications task from
not visible ServiceThread to a new visible NotificationThread. This version of
the change also
Hi Severin,
Sorry, this is not an area that I have any expertise in. However, I did
confirm that it fixes the NPE I was seeing with JShellHeapDumpTest.java,
which brings up a question. You said this happens with -Xcomp, but I was
never using -Xcomp. Might it also be triggered without -Xcomp?
Hi Serguei,
If someone changes THREADS_COUNT, then SuspenderIndex would no longer do
what we want. I suggest passing in something like "first" and "last".
120 * - main thread registers tested threads withing the native
agent library
Should be "within".
I think you should add a
Hi Serguei,
Looks good.
The only note:
(libSuspendWithCurrentThread.cpp)
115 check_jvmti_status(jni, err, "resumeTestedThreads: error in
ResumeThreadList");
This check in a cycle looks useless.
No need for new webrev.
--alex
On 09/30/2019 22:45, serguei.spit...@oracle.com wrote:
Hi
On 10/1/19 2:59 AM, Severin Gehwolf wrote:
Hi Chris,
On Mon, 2019-09-30 at 12:59 -0700, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8231288
http://cr.openjdk.java.net/~cjplummer/8231288/webrev.00/index.html
There were a number of jmap
Summary: Remove RedefineClasses adjustment and test, but improve
checking for method/class matching.
Tested with tier1 with -Xcheck:jni locally, and tier1 on Oracle platforms.
open webrev at http://cr.openjdk.java.net/~coleenp/2019/8229900.01/webrev
bug link
Hi,
Please review this OpenJDK 8u vs. Oracle JDK 8 parity patch. I wasn't
sure whether I need review for this one as the bug in question is a JDK
8-only bug and the patch applies as-is. Anyway, here it is:
Bug: https://bugs.openjdk.java.net/browse/JDK-8195088
webrev:
Hi Chris,
On Mon, 2019-09-30 at 12:59 -0700, Chris Plummer wrote:
> Hello,
>
> Please review the following:
>
> https://bugs.openjdk.java.net/browse/JDK-8231288
> http://cr.openjdk.java.net/~cjplummer/8231288/webrev.00/index.html
>
> There were a number of jmap issues that
On Tue, 2019-10-01 at 10:29 +0100, Andrew Haley wrote:
> On 9/27/19 1:12 PM, Severin Gehwolf wrote:
> > The proposed patch handles serialized null scopes similar to the
> > hotspot side of things, by returning a null scope. CompiledVFrame
> > already deals with null scopes when in debugging mode.
On 9/27/19 1:12 PM, Severin Gehwolf wrote:
> The proposed patch handles serialized null scopes similar to the
> hotspot side of things, by returning a null scope. CompiledVFrame
> already deals with null scopes when in debugging mode.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8196969
>
Anyone? Chris maybe?
On Fri, 2019-09-27 at 14:12 +0200, Severin Gehwolf wrote:
> Hi,
>
> Could I please get reviews for this SA fix? The issue only happens
> intermittently and with -Xcomp. The new regression test reproduces the
> issue somewhat reliably. I got 10/10 fails for unpatched, but
Hi David,
I've started reviewing this and expecting to finish it tomorrow.
Thanks,
Serguei
On 9/30/19 15:52, David Holmes wrote:
ping!
Thanks,
David
On 24/09/2019 3:09 pm, David Holmes wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8231289
webrev:
Hi David,
Thank you for review!
I'll fix the typos.
Thanks,
Serguei
On 9/30/19 23:15, David Holmes wrote:
Hi Serguei,
Seems okay - thanks for the explanation.
A couple of typos in the Java file:
SuspenThreadList
finction
Thanks,
David
On 1/10/2019 3:45 pm, serguei.spit...@oracle.com
Hi Serguei,
Seems okay - thanks for the explanation.
A couple of typos in the Java file:
SuspenThreadList
finction
Thanks,
David
On 1/10/2019 3:45 pm, serguei.spit...@oracle.com wrote:
Hi Chris, David and Alex,
The updated webrev is:
28 matches
Mail list logo
