Hi Daniil,
You might also want to put the max size check in the check_concurrent_work code:
+ // Resize if we have more items than preferred load factor
+ if ( load_factor > PREF_AVG_LIST_LEN &&
!_local_table->is_max_size_reached()) {
so that we don't keep waking up the service thread fo
Hi Daniil,
On 4/10/2019 1:38 pm, Daniil Titov wrote:
Hi David and Robbin,
Please review a new version of the fix that makes the service thread
responsible for the thread table growth.
Webrev: http://cr.openjdk.java.net/~dtitov/8231666/webrev.02/
Bug: https://bugs.openjdk.java.net/browse/JDK-
Okay, to allow for me to make forward progress here I've decided to
follow the "principle of least brokenness" ;-)
Recap: Because of JVMTI event callbacks it is possible for a thread to
set its current pending monitor as a JvmtiRawMonitor when it was already
set for an ObjectMonitor. This is b
Hi David and Robbin,
Please review a new version of the fix that makes the service thread
responsible for the thread table growth.
Webrev: http://cr.openjdk.java.net/~dtitov/8231666/webrev.02/
Bug: https://bugs.openjdk.java.net/browse/JDK-8231666
Testing: Mach5 tier1, tier2, and tier3 tests
Hi Serguei,
Just coming back to your original review emails to ensure everything
covered.
On 2/10/2019 6:57 pm, serguei.spit...@oracle.com wrote:
I forgot to say, the fix looks pretty good to me.
Also, it is quite educational. :)
Thanks :)
On 10/2/19 01:51, serguei.spit...@oracle.com wrot
On 4/10/2019 10:01 am, Daniel D. Daugherty wrote:
On 10/3/19 7:35 PM, serguei.spit...@oracle.com wrote:
If I remember correctly it is a scenario where this issue also comes
to the picture:
https://bugs.openjdk.java.net/browse/JDK-8033399
I do not really understand how shared ParkEvent can be
On 10/3/19 7:35 PM, serguei.spit...@oracle.com wrote:
On 10/3/19 3:33 PM, David Holmes wrote:
On 4/10/2019 3:15 am, serguei.spit...@oracle.com wrote:
On 10/3/19 03:13, David Holmes wrote:
Hi Dan,
On 3/10/2019 3:20 am, Daniel D. Daugherty wrote:
Sorry for the delay in reviewing this one... I
On 10/3/19 3:33 PM, David Holmes wrote:
On 4/10/2019 3:15 am, serguei.spit...@oracle.com wrote:
On 10/3/19 03:13, David Holmes wrote:
Hi Dan,
On 3/10/2019 3:20 am, Daniel D. Daugherty wrote:
Sorry for the delay in reviewing this one... I've been playing
whack-a-mole
with Robbin's MoCrazy
Hi David and Serguei,
Thank you, for reviewing this change!
Best regards,
Daniil
On 10/2/19, 4:24 PM, "serguei.spit...@oracle.com"
wrote:
Hi Daniil,
+1
I also prefer (agree with) a new VM option to opt-out from the new behavior.
Sorry for some latency in the review and
On 4/10/2019 3:15 am, serguei.spit...@oracle.com wrote:
On 10/3/19 03:13, David Holmes wrote:
Hi Dan,
On 3/10/2019 3:20 am, Daniel D. Daugherty wrote:
Sorry for the delay in reviewing this one... I've been playing
whack-a-mole
with Robbin's MoCrazy test and my AsyncMonitorDeflation bits...
Hi Tom,
On Thu, 2019-10-03 at 11:14 -0700, Tom Rodriguez wrote:
> I think your fix is a reasonable way to resolve the NPE. We certainly
> shouldn't try to create a ScopeDesc from an invalid location. Maybe
> getPCDescNearDbg should try to do a better job finding a PcDesc with a
> valid scope_
I think your fix is a reasonable way to resolve the NPE. We certainly
shouldn't try to create a ScopeDesc from an invalid location. Maybe
getPCDescNearDbg should try to do a better job finding a PcDesc with a
valid scope_decode_offset instead? Something like this maybe?
diff -r c414c554b38b
No, I don't think that's necessary.
thanks,
Chris
On 10/3/19 10:33 AM, Fairoz Matte wrote:
Hi Chris,
Thanks for the review, do you want me to cover this with regression test? I
suspect that it was not required.
Thanks,
Fairoz
-Original Message-
From: Chris Plummer
Sent: Thursday, O
Hi Serguei,
Thanks for the review.
Thanks,
Fairoz
-Original Message-
From: Serguei Spitsyn
Sent: Thursday, October 3, 2019 10:26 PM
To: Fairoz Matte ; serviceability-dev
Subject: Re: RFR (S) 8216352: SA: ClhsdbLauncher should throw errors on
Unrecognized commands
Hi Fairoz,
Looks g
Hi Chris,
Thanks for the review, do you want me to cover this with regression test? I
suspect that it was not required.
Thanks,
Fairoz
-Original Message-
From: Chris Plummer
Sent: Thursday, October 3, 2019 9:55 PM
To: Fairoz Matte ; serviceability-dev
Subject: Re: RFR (S) 8216352: SA
On 10/3/19 03:13, David Holmes wrote:
Hi Dan,
On 3/10/2019 3:20 am, Daniel D. Daugherty wrote:
Sorry for the delay in reviewing this one... I've been playing
whack-a-mole
with Robbin's MoCrazy test and my AsyncMonitorDeflation bits...
No problem - your contribution made the wait worthwhile :
Hi Fairoz,
Looks good.
Thanks,
Serguei
On 10/3/19 06:47, Fairoz Matte wrote:
Hi,
Please review a tiny change to handle unrecognized command options for
ClhsdbLauncher test.
This patch is already proposed by Gary Adams in comments section.
JBS: https://bugs.openjdk.java.net/browse/JDK-82163
Hi Fairoz,
I think it looks fine. I guess this implies that we don't have a test
that verifies that we get "Unrecognized command." if a bad command is
passed, in which case a different approach would be needed (perhaps a
flag that says to verify that we get "Unrecognized command." instead of
Hi Severin,
I've cc'd Tom Rodriquez who said he would have a look.
thanks,
Chris
On 10/1/19 12:51 PM, Chris Plummer wrote:
Hi Severin,
Sorry, this is not an area that I have any expertise in. However, I
did confirm that it fixes the NPE I was seeing with
JShellHeapDumpTest.java, which brin
Hi,
Please review a tiny change to handle unrecognized command options for
ClhsdbLauncher test.
This patch is already proposed by Gary Adams in comments section.
JBS: https://bugs.openjdk.java.net/browse/JDK-8216352
Webrev: http://cr.openjdk.java.net/~fmatte/8216352/webrev.00/
Thanks,
Fairoz
On 3/10/2019 11:11 pm, Daniel D. Daugherty wrote:
On 10/3/19 6:13 AM, David Holmes wrote:
Hi Dan,
On 3/10/2019 3:20 am, Daniel D. Daugherty wrote:
Sorry for the delay in reviewing this one... I've been playing
whack-a-mole
with Robbin's MoCrazy test and my AsyncMonitorDeflation bits...
N
On 10/3/19 6:13 AM, David Holmes wrote:
Hi Dan,
On 3/10/2019 3:20 am, Daniel D. Daugherty wrote:
Sorry for the delay in reviewing this one... I've been playing
whack-a-mole
with Robbin's MoCrazy test and my AsyncMonitorDeflation bits...
No problem - your contribution made the wait worthwhile
Thank you for the comments, David.
On 10/3/19 3:04 AM, David Holmes wrote:
Hi Coleen,
On 2/10/2019 11:36 pm, coleen.phillim...@oracle.com wrote:
On 10/2/19 12:53 AM, David Holmes wrote:
Hi Coleen,
Sorry rather long-winded reply ...
On 1/10/2019 11:52 pm, coleen.phillim...@oracle.com wro
Hi Dan,
On 3/10/2019 3:20 am, Daniel D. Daugherty wrote:
Sorry for the delay in reviewing this one... I've been playing whack-a-mole
with Robbin's MoCrazy test and my AsyncMonitorDeflation bits...
No problem - your contribution made the wait worthwhile :)
On 9/24/19 1:09 AM, David Holmes wro
Could I please get a second review for this?
Thanks,
Severin
On Tue, 2019-10-01 at 10:29 +0100, Andrew Haley wrote:
> On 9/27/19 1:12 PM, Severin Gehwolf wrote:
> > The proposed patch handles serialized null scopes similar to the
> > hotspot side of things, by returning a null scope. CompiledVFra
Hi Coleen,
On 2/10/2019 11:36 pm, coleen.phillim...@oracle.com wrote:
On 10/2/19 12:53 AM, David Holmes wrote:
Hi Coleen,
Sorry rather long-winded reply ...
On 1/10/2019 11:52 pm, coleen.phillim...@oracle.com wrote:
Summary: Remove RedefineClasses adjustment and test, but improve
checking
26 matches
Mail list logo
