On 10/9/19 11:36 PM, David Holmes wrote:
Hi Yasumasa,
On 10/10/2019 3:55 pm, Yasumasa Suenaga wrote:
Hi all,
Please review this change:
JBS: https://bugs.openjdk.java.net/browse/JDK-8232084
webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8232084/webrev.00/
I tried to build OpenJDK on
I think the +1 gets rid of the warning, but it also means there is no
need for the following line that sets buf[len].
Chris
On 10/9/19 11:31 PM, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
The fix in src/hotspot/cpu/x86/macroAssembler_x86.hpp looks Okay.
But I don't understand why you nee
Hi Yasumasa,
On 10/10/2019 3:55 pm, Yasumasa Suenaga wrote:
Hi all,
Please review this change:
JBS: https://bugs.openjdk.java.net/browse/JDK-8232084
webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8232084/webrev.00/
I tried to build OpenJDK on Fedora 30 x64 with GCC 9.2.1, but it was
Hi Yasumasa,
The fix in src/hotspot/cpu/x86/macroAssembler_x86.hpp looks Okay.
But I don't understand why you need this fix in
src/hotspot/share/services/diagnosticArgument.cpp ?:
char* buf = NEW_RESOURCE_ARRAY(char, len + 1);
- strncpy(b
Hi all,
Please review this change:
JBS: https://bugs.openjdk.java.net/browse/JDK-8232084
webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8232084/webrev.00/
I tried to build OpenJDK on Fedora 30 x64 with GCC 9.2.1, but it was failed in
macroAssembler_x86.hpp and diagnosticArgument.cpp .
(P
Hi Daniil,
Looks good.
Thanks,
Serguei
On 10/9/19 15:45, Daniil Titov wrote:
Please review a small fix [1] that removes references to obsolete XDebug flag from JDWP
help returned by "java -Xrunjdwp:help" command.
A new CSR [2] was created for these changes and needs to be reviewed.
[1] Webr
+1 on each
Thanks,
David
On 10/10/2019 9:04 am, Alex Menkov wrote:
LGTM
I reviewed CSR as well
--alex
On 10/09/2019 15:45, Daniil Titov wrote:
Please review a small fix [1] that removes references to obsolete
XDebug flag from JDWP help returned by "java -Xrunjdwp:help" command.
A new CSR [2
LGTM
I reviewed CSR as well
--alex
On 10/09/2019 15:45, Daniil Titov wrote:
Please review a small fix [1] that removes references to obsolete XDebug flag from JDWP
help returned by "java -Xrunjdwp:help" command.
A new CSR [2] was created for these changes and needs to be reviewed.
[1] Webrev:
Please review a small fix [1] that removes references to obsolete XDebug flag
from JDWP help returned by "java -Xrunjdwp:help" command.
A new CSR [2] was created for these changes and needs to be reviewed.
[1] Webrev: http://cr.openjdk.java.net/~dtitov/8227231/webrev.01/
[2] CSR: https://bugs.op
Ok. Good to go then.
Chris
On 10/9/19 2:03 PM, Ioi Lam wrote:
Hi Chris,
Thanks for the review. I moved the declaration of n and m to inside
the "if" block. For ps_pread vs ps_pdread, I am not sure why the
symbol is different on mac vs linux. Maybe the purpose is to avoid
conflicting with bu
Hi Chris,
Thanks for the review. I moved the declaration of n and m to inside the
"if" block. For ps_pread vs ps_pdread, I am not sure why the symbol is
different on mac vs linux. Maybe the purpose is to avoid conflicting
with built-in symbols on the platform? Since this function is used by
o
> I kept the 128M
That's good.
Cheers, Richard.
-Original Message-
From: Per Liden
Sent: Wednesday, October 9, 2019 8:24 PM
To: Reingruber, Richard ; hotspot-compiler-dev
Cc: serviceability-dev@openjdk.java.net
Subject: Re: RFR: 8232056: GetOwnedMonitorInfoWithEATest.java fails wit
Hi Ioi,
It looks good to me - nice consolidation.
Thanks,
Serguei
On 10/7/19 23:37, Ioi Lam wrote:
https://bugs.openjdk.java.net/browse/JDK-8231986
http://cr.openjdk.java.net/~iklam/jdk14/8231986-consolidate-ps-core.v01/
One of my upcoming CDS changes (JDK-8231610) would affect the
duplicat
Hi Ioi,
Overall the changes look fine. A couple of minor things:
Any reason not to fix the ps_pread/ps_pdread naming issue rather than
just map it with a #define?
In init_classsharing_workaround(), I think the "n" and "m" declarations
should be inside the "if" block.
thanks,
Chris
On 10/
Thanks for reviewing, Richard. I kept the 128M, since that was what I
ran through testing, and I'd like to push this as soon as possible since
it's causing noise in our CI.
If someone wants to remove the -Xmx128M, feel free to file a follow up.
However, note that the test might then consume mo
Thanks for reviewing, David!
/Per
On 10/9/19 3:53 PM, David Holmes wrote:
Hi Per,
Thanks for fixing this one.
On 9/10/2019 11:19 pm, Per Liden wrote:
The newly added:
GetOwnedMonitorInfoWithEATest.java
GetOwnedMonitorStackDepthInfoWithEATest.java
fail when run with ZGC as they set -Xmx to
Thanks, Chris!
Serguei
On 10/9/19 10:14, Chris Plummer wrote:
Hi Serguei,
It's ok to push.
thanks,
Chris
On 10/8/19 10:47 PM, serguei.spit...@oracle.com wrote:
Hi Serguei,
It's ok to push.
thanks,
Chris
On 10/8/19 10:47 PM, serguei.spit...@oracle.com wrote:
Hi Chris,
Please, let me know if you have more thoughts on this or it is
okay to push as i
On Tue, Oct 8, 2019 at 12:52 AM Daniil Titov
wrote:
> I will sponsor this change.
>
On Tue, Oct 8, 2019 at 1:01 AM serguei.spit...@oracle.com <
serguei.spit...@oracle.com> wrote:
> Looks good.
>
On Wed, Oct 9, 2019 at 12:20 AM Daniil Titov
wrote:
> I pushed the changes.
>
> The changeset: ht
Hi Per,
Sorry about the problem. Your change looks good to me, I'm not a reviewer
though.
Alternatively you can just remove the lines that set -Xmx (and -Xms). The lines
are not needed in these tests (copied from other tests). I've tried that
successfully just now.
Thanks, Richard.
-Orig
Hi Per,
Thanks for fixing this one.
On 9/10/2019 11:19 pm, Per Liden wrote:
The newly added:
GetOwnedMonitorInfoWithEATest.java
GetOwnedMonitorStackDepthInfoWithEATest.java
fail when run with ZGC as they set -Xmx to 32M which is too. Bumping to
128m.
Seems okay. I can't see any specific re
The newly added:
GetOwnedMonitorInfoWithEATest.java
GetOwnedMonitorStackDepthInfoWithEATest.java
fail when run with ZGC as they set -Xmx to 32M which is too. Bumping to
128m.
Bug: https://bugs.openjdk.java.net/browse/JDK-8232056
Webrev: http://cr.openjdk.java.net/~pliden/8232056/webrev.0
/Pe
22 matches
Mail list logo
