Re: RFR (XS): 8232182: RedefineNestmateAttr/TestNestmateAttr.java failes due to ObjectCollectedException

2019-10-15 Thread Martin Buchholz
A slightly cleaner way to do this is probably via try { ... } finally { reachabilityFence(topLevelHostA); } instead of a static field On Mon, Oct 14, 2019 at 12:15 AM David Holmes wrote: > Bug: https://bugs.openjdk.java.net/browse/JDK-8232182 > webrev: http://cr.openjdk.java.net/~dholmes/82321

Re: RFR (XS): 8232182: RedefineNestmateAttr/TestNestmateAttr.java failes due to ObjectCollectedException

2019-10-15 Thread David Holmes
Hi Martin, On 16/10/2019 2:38 am, Martin Buchholz wrote: A slightly cleaner way to do this is probably via try { ... } finally { reachabilityFence(topLevelHostA); } instead of a static field The reachability is not confined to that method. The class needs to be kept alive so that the method

Re: RFR: 8231943: ZGC: Enable serviceability/dcmd/gc/RunGCTest

2019-10-15 Thread Erik Osterlund
+1 /Erik > On 10 Oct 2019, at 14:28, Per Liden wrote: > > (CC:ing serviceability-dev) > >> On 10/7/19 2:38 PM, Per Liden wrote: >> This test is currently disabled for ZGC, but it can easily be enabled by >> adjusting the expected log string. ZGC doesn't print "Pause Full", but it >> still p