Hi Joe,
Looks good.
Thanks,
Serguei
On 10/16/19 23:15, Joe Darcy wrote:
Hello,
Please review a serial warning update of three exceptions types in the
jdk.jdi module.
JDK-8232448: Suppress warnings on non-serializable non-transient
instance fields in jdk.jdi
http://cr.openjdk.jav
Thanks Serguei!
/Per
On 2019-10-17 01:21, serguei.spit...@oracle.com wrote:
Hi Per,
Looks good.
Thanks,
Serguei
On 10/15/19 23:56, Erik Osterlund wrote:
+1
/Erik
On 10 Oct 2019, at 14:28, Per Liden wrote:
(CC:ing serviceability-dev)
On 10/7/19 2:38 PM, Per Liden wrote:
This test is
Hi Joe,
These look ok.
A few of them might be handled by making them transient, but
SuppressWarnings
calls more attention to them as fields that are being serialized, even
indirectly.
The presence of a writeReplace method weakens the coupling of the fields
to the serialized values.
Roger
Thanks for the reviews.
> -Original Message-
> From: Chris Plummer
> Sent: Mittwoch, 16. Oktober 2019 21:30
> To: Alex Menkov ; Langer, Christoph
> ; OpenJDK Serviceability d...@openjdk.java.net>
> Subject: Re: RFR: 8232370: Refactor some com.sun.jdi tests to enable IDE
> integration
>
Hi Roger,
I would certainly be in favor of a more thorough review of the use of
serialization in the management modules by the serviceability team as
follow-up work.
Cheers,
-Joe
On 10/17/2019 11:29 AM, Roger Riggs wrote:
Hi Joe,
These look ok.
A few of them might be handled by making th
Hi all,
I pushed the change: https://hg.openjdk.java.net/jdk/jdk/rev/9f5b92d5a1b2
I hope PRAGMA_STRINGOP_TRUNCATION_IGNORED which introduced in this commit will
be used when similar issues occur in future.
Thanks for all your help! ありがとう!
Yasumasa
On 2019/10/17 13:54, Ioi Lam wrote:
On
Hello,
Please review the following for problem listing
serviceability/sa/ClhsdbJstackXcompStress.java. This is a new test that
is failing once or twice a day on windows-x64 due to 8231635. Note I
also problem listed the test for solaris due to 8193639. Although I did
not actually see this fai
That seems fine Chris.
Thanks,
David
On 18/10/2019 1:57 pm, Chris Plummer wrote:
Hello,
Please review the following for problem listing
serviceability/sa/ClhsdbJstackXcompStress.java. This is a new test that
is failing once or twice a day on windows-x64 due to 8231635. Note I
also problem l