Re: RFR: 8233285: Demangling C++ symbols in jhsdb jstack --mixed

Just for the record this was fixed by "8233600: cross-builds fails after JDK-8233285" David On 6/11/2019 11:50 pm, Yasumasa Suenaga wrote: Hi, Thanks for telling it me. I removed "BUILD_" from Makefile as Erik said, then it works fine on my Linux box: ``` diff -r a3b046720c3b make/lib/Lib-

Re: RFR: 8233600: cross-builds fails after JDK-8233285

Thank you! On 06.11.2019 19:18, Erik Joelsson wrote: Looks good! Verified the same patch with all our available cross compile builds. /Erik On 2019-11-06 06:31, Boris Ulasevich wrote: Hi, Indeed, the fix is quite evident. I checked it works for arm32/aarch cross-compilation builds. http:

Re: RFR: 8233600: cross-builds fails after JDK-8233285

Looks good! Verified the same patch with all our available cross compile builds. /Erik On 2019-11-06 06:31, Boris Ulasevich wrote: Hi, Indeed, the fix is quite evident. I checked it works for arm32/aarch cross-compilation builds. http://bugs.openjdk.java.net/browse/JDK-8233600 http://cr.op

Re: RFR: 8233600: cross-builds fails after JDK-8233285

On 11/6/19 3:31 PM, Boris Ulasevich wrote: > http://bugs.openjdk.java.net/browse/JDK-8233600 > http://cr.openjdk.java.net/~bulasevich/8233600/webrev.00 This looks good to me. Fixes aarch64 cross-compilation for me. -- Thanks, -Aleksey signature.asc Description: OpenPGP digital signature

RFR: 8233600: cross-builds fails after JDK-8233285

Hi, Indeed, the fix is quite evident. I checked it works for arm32/aarch cross-compilation builds. http://bugs.openjdk.java.net/browse/JDK-8233600 http://cr.openjdk.java.net/~bulasevich/8233600/webrev.00 regards, Boris On 06.11.2019 16:33, Erik Joelsson wrote: I looked closer at it now and t

Re: RFR: 8233285: Demangling C++ symbols in jhsdb jstack --mixed

Hi, Thanks for telling it me. I removed "BUILD_" from Makefile as Erik said, then it works fine on my Linux box: ``` diff -r a3b046720c3b make/lib/Lib-jdk.hotspot.agent.gmk --- a/make/lib/Lib-jdk.hotspot.agent.gmkWed Nov 06 21:49:30 2019 +0900 +++ b/make/lib/Lib-jdk.hotspot.agent.gmk

Re: RFR: 8233285: Demangling C++ symbols in jhsdb jstack --mixed

I looked closer at it now and the build change is not good. Any toolchain definition with BUILD in the name, like TOOLCHAIN_BUILD_LINK_CXX, is only meant to be used for building tools that are run during the build. I believe the fix is to just remove the "BUILD_". /Erik On 2019-11-06 05:13,

Re: RFR: 8233285: Demangling C++ symbols in jhsdb jstack --mixed

On 4/11/2019 8:27 pm, Magnus Ihse Bursie wrote: On 2019-11-02 13:43, Daniel D. Daugherty wrote: Since this review contains build changes, I've added build-dev@... Thanks Dan for noticing this and cc:ing us. Yasumasa: build changes look fine. Thanks. This change broke all cross-compilation.