8234624: jstack mixed mode should refer DWARF

2019-11-21 Thread Yasumasa Suenaga
Hi all, I tried to get mixed stack via `jhsdb jstack --mixed`, but I couldn't. (See JBS for details) https://bugs.openjdk.java.net/browse/JDK-8234624 I think it is caused by DWARF. AMD64 needs DWARF for stack unwinding, but SA does not handle it. So I created a patch. It works fine on my Fed

Re: RFR (S) 8173361: various crashes in JvmtiExport::post_compiled_method_load

2019-11-21 Thread coleen . phillimore
On 11/21/19 8:33 PM, serguei.spit...@oracle.com wrote: Hi Coleen, Looks good in general. Serguei,  Thank you for reviewing this. Nice approach, thank you for working on this! It is great to get rid of the nmethodLocker's in JvmtiDeferredEvent class. I have some questions/comments. http:/

Re: RFR (S) 8173361: various crashes in JvmtiExport::post_compiled_method_load

2019-11-21 Thread serguei . spitsyn
Hi Coleen, Looks good in general. Nice approach, thank you for working on this! It is great to get rid of the nmethodLocker's in JvmtiDeferredEvent class. I have some questions/comments. http://cr.openjdk.java.net/~coleenp/2019/8173361.03/webrev/src/hotspot/share/runtime/serviceThread.cpp.fram

Re: RFR (S) 8173361: various crashes in JvmtiExport::post_compiled_method_load

2019-11-21 Thread coleen . phillimore
On 11/21/19 10:32 AM, erik.osterl...@oracle.com wrote: Hi Coleen, Thanks for removing the nmethodLocker. I'm on a mission to remove all nmethod lockers, and this one is really nasty. Thanks Erik, and thank you for the help. I'm trying to help you get rid of nmethodLockers but there's anoth

Re: RFR (S) 8173361: various crashes in JvmtiExport::post_compiled_method_load

2019-11-21 Thread erik . osterlund
Hi Coleen, Thanks for removing the nmethodLocker. I'm on a mission to remove all nmethod lockers, and this one is really nasty. Looks good. Thanks, /Erik On 11/21/19 3:12 PM, coleen.phillim...@oracle.com wrote: Please review a new version of this change that keeps the nmethod from being un

Re: RFR (S) 8173361: various crashes in JvmtiExport::post_compiled_method_load

2019-11-21 Thread coleen . phillimore
Please review a new version of this change that keeps the nmethod from being unloaded, after it is added to the deferred event queue: http://cr.openjdk.java.net/~coleenp/2019/8173361.03/webrev/index.html Ran the test that failed 100 times without failure, tier1 on Oracle supported platforms,