Ping.
Updated copyright header (to 2020) in place.
--alex
On 12/19/2019 15:34, Alex Menkov wrote:
Hi all,
Please review a fix for
https://bugs.openjdk.java.net/browse/JDK-8235846
webrev:
http://cr.openjdk.java.net/~amenkov/jdk15/WinDbg_improve/webrev.01/
Main goal of the change is to improve
On 1/7/20 11:45 AM, coleen.phillim...@oracle.com wrote:
On 1/7/20 2:25 PM, serguei.spit...@oracle.com wrote:
Chris,
The macro NOT_JVMTI_RETURN is never used outside of the prims/ folder.
Also, there is more work to get rid of the JVMTI code in the
ServiceThread.
I don't know how important
On 1/7/20 2:25 PM, serguei.spit...@oracle.com wrote:
Chris,
The macro NOT_JVMTI_RETURN is never used outside of the prims/ folder.
Also, there is more work to get rid of the JVMTI code in the
ServiceThread.
I don't know how important is this for the minimal build.
So, I'd leave it alone for
Chris,
The macro NOT_JVMTI_RETURN is never used outside of the prims/ folder.
Also, there is more work to get rid of the JVMTI code in the ServiceThread.
I don't know how important is this for the minimal build.
So, I'd leave it alone for now and just fix the build issue.
Thanks,
Serguei
On 1/7
Hi Serguei,
The reason you don't see a build failure is because the implementation
of ServiceThread::enqueue_deferred_event() is not in a JVMTI file that
gets excluded from minimalVM builds, thus it is still callable and
linkable. If you choose to use NOT_JVMTI_RETURN for it in the header
fil
Hi Chris,
The slowdebug minimal build does not fail without NOT_JVMTI_RETURN in
the ServiceThread::enqueue_deferred_event().
I'm curious why and will check if it is really needed.
If so, will add it as well.
Thanks,
Serguei
On 1/6/20 8:05 PM, serguei.spit...@oracle.com wrote:
Hi Chris,
Good
