On 1/22/20 12:23 PM, Alex Menkov wrote:
Hi Chris,
On 01/17/2020 14:36, Chris Plummer wrote:
Hi Alex,
I assume that the following:
65 operator T* () const {
66 return m_ptr;
67 }
Is used here:
183 AutoArrayPtr errmsg(new char[strlen(str) + 32]); \
184 if (err
Looks good.
Chris
On 1/22/20 3:30 PM, Daniil Titov wrote:
Hi Chris,
Please review a new version of the fix [1] that converts the check to the
assert.
Also, I'm not clear on the need for the *pkernelLoad initialization. It
seems this is attempting to fix a different issue, but it's a
Hi Chris,
Please review a new version of the fix [1] that converts the check to the
assert.
>Also, I'm not clear on the need for the *pkernelLoad initialization. It
>seems this is attempting to fix a different issue, but it's already
>initialized to 0 at the start of the function.
Hi Chris,
On 01/17/2020 14:36, Chris Plummer wrote:
Hi Alex,
I assume that the following:
65 operator T* () const {
66 return m_ptr;
67 }
Is used here:
183 AutoArrayPtr errmsg(new char[strlen(str) + 32]); \
184 if (errmsg == nullptr) { \
I just don't underst
LGTM
--alex
On 01/16/2020 11:41, Chris Plummer wrote:
Hi,
Here's a new webrev:
http://cr.openjdk.java.net/~cjplummer/8236913/webrev.01/
Since the last webrev:
- debugDispatch.c is and the header files (other than debugDispatch.h)
are unchanged other
than renaming from XXX_Cmds to XXX
> On Jan 22, 2020, at 11:06 AM, Mandy Chung wrote:
>
>
>
> On 1/22/20 1:53 AM, Severin Gehwolf wrote:
>> Hi Mandy,
>>
>> Thanks again for the review! I'll be sure to fix things. Some of the
>> issues you've pointed out probably pre-existed in old code. Some became
>> more complicated since u
Hi Serguei,
Thanks for reviewing!
I updated the patch to reflect your suggestions, very good!
It also includes a fix to allow re-connecting an agent after disconnect,
namely move setup of the trackingEnv and deletedSignatureBag to
_activate() to ensure have those structures after re-connect.
htt
On 1/22/20 1:53 AM, Severin Gehwolf wrote:
Hi Mandy,
Thanks again for the review! I'll be sure to fix things. Some of the
issues you've pointed out probably pre-existed in old code. Some became
more complicated since unlimited in cgroupv1 is a large long value in
files. Anyway, I'll update it
Thanks. Created JDK-8237639.
StefanK
On 2020-01-22 10:50, David Holmes wrote:
Hi Stefan,
Thanks David. Would you accept it if I created a follow-up RFR to
investigate if we could change order of the combined flags?
Sure, no problem.
Thanks,
David
On 22/01/2020 6:58 pm, Stefan Karlsson wr
Hi Mandy,
Thanks again for the review! I'll be sure to fix things. Some of the
issues you've pointed out probably pre-existed in old code. Some became
more complicated since unlimited in cgroupv1 is a large long value in
files. Anyway, I'll update it.
On Tue, 2020-01-21 at 16:09 -0800, Mandy Chun
Hi Stefan,
Thanks David. Would you accept it if I created a follow-up RFR to investigate if we could change order of the combined flags?
Sure, no problem.
Thanks,
David
On 22/01/2020 6:58 pm, Stefan Karlsson wrote:
Hi David,
On 2020-01-22 05:28, David Holmes wrote:
Hi Stefan,
Thanks for
Hi David,
On 2020-01-22 05:28, David Holmes wrote:
Hi Stefan,
Thanks for tackling this.
On 22/01/2020 12:58 am, Stefan Karlsson wrote:
Hi all,
Please review this patch to change our usages of LingeredApp and
getVmOptions() to instead use getTestJavaOpts().
https://cr.openjdk.java.net/~ste
Hi Chris,
On 2020-01-21 20:52, Chris Plummer wrote:
Hi Stefan,
Can you explain the un-commenting of the code in JpsHelper.java?
The comment was not removed, but moved over to testVmArgs.
The reason for the change is that I need getVmArgs() to return a
String[] instead of List. So, I initial
> On 21/01/2020 07:15, Yangfei (Felix) wrote:
> > Hi Daniel,
> >
> >Thanks for reviewing the patch. Will do the push.
> >
> Is this a documented and supported property? I assume so, in which case you
> should create a CSR. I think a Release-Note sub-task will needed too so that
> it
> gets in
14 matches
Mail list logo
