On 1/23/20 3:12 PM, Alex Menkov wrote:
On 01/23/2020 13:56, Chris Plummer wrote:
On 1/23/20 1:16 PM, Alex Menkov wrote:
On 01/23/2020 12:35, Chris Plummer wrote:
On 1/23/20 11:21 AM, Alex Menkov wrote:
...skipped...
I don't care much about this change and can revert it.
OK.
What does
On 01/23/2020 13:56, Chris Plummer wrote:
On 1/23/20 1:16 PM, Alex Menkov wrote:
On 01/23/2020 12:35, Chris Plummer wrote:
On 1/23/20 11:21 AM, Alex Menkov wrote:
...skipped...
I don't care much about this change and can revert it.
OK.
What does the "OK" mean? :)
Do you prefer revert
On 1/23/20 1:16 PM, Alex Menkov wrote:
On 01/23/2020 12:35, Chris Plummer wrote:
On 1/23/20 11:21 AM, Alex Menkov wrote:
...skipped...
Why is the following not placed at the end if the "if" block:
299 AddRef();
300 return S_OK;
The following was removed. It's not clear to me wh
On 01/23/2020 12:35, Chris Plummer wrote:
On 1/23/20 11:21 AM, Alex Menkov wrote:
...skipped...
Why is the following not placed at the end if the "if" block:
299 AddRef();
300 return S_OK;
The following was removed. It's not clear to me why it was and what
the impact is:
2
On 1/23/20 11:21 AM, Alex Menkov wrote:
Hi Chris,
On 01/22/2020 19:21, Chris Plummer wrote:
On 1/22/20 12:23 PM, Alex Menkov wrote:
Hi Chris,
On 01/17/2020 14:36, Chris Plummer wrote:
Hi Alex,
I assume that the following:
65 operator T* () const {
66 return m_ptr;
67 }
Is
Hi Chris,
On 01/22/2020 19:21, Chris Plummer wrote:
On 1/22/20 12:23 PM, Alex Menkov wrote:
Hi Chris,
On 01/17/2020 14:36, Chris Plummer wrote:
Hi Alex,
I assume that the following:
65 operator T* () const {
66 return m_ptr;
67 }
Is used here:
183 AutoArrayPtr err
Hi Ralf,
belated, but looks good to me.
Thanks, Thomas
On Mon, Dec 16, 2019 at 1:28 PM Schmelter, Ralf
wrote:
> I forgot to post the updated webrev:
> http://cr.openjdk.java.net/~rschmelter/webrevs/8234510/webrev.2/
>
> In addition to the changes requested by Thomas, I also renamed the entries
