Re: RFR: JDK-8234935: JdwpListenTest.java and JdwpAttachTest.java getting bind failures on Windows 2016 hosts

2020-02-07 Thread Alex Menkov
Updated webrev: http://cr.openjdk.java.net/~amenkov/jdk15/JdwpTestsTeredo/webrev.02/ I decided to go 2nd way. --alex On 02/06/2020 17:31, Chris Plummer wrote: Either is fine by me. Chris On 2/6/20 3:40 PM, Alex Menkov wrote: Hi Chris, Thank you for the review. So we have 2 ways - create ne

Re: RFR(S) 8238585: Use handshake for JvmtiEventControllerPrivate::enter_interp_only_mode() and don't make compiled methods on stack not_entrant

2020-02-07 Thread serguei.spit...@oracle.com
Hi Richard, It looks good to me. I can't comment on compiled methods non-entrancy. What exact tests do you run to verify the fix? Thanks, Serguei On 2/6/20 04:39, Reingruber, Richard wrote: Hi, could I please get reviews for this small enhancement: Webrev: http://cr.openjdk.java.net/~rrich

[15] RFR 8238633: JVMTI heap walk should consult GC for marking oops

2020-02-07 Thread Zhengyu Gu
Hi, I would like purpose this change that allows GC to provide ObjectMarker during JVMTI heap walk. Currently, JVMTI heap walk uses oop markword's 'marked' pattern to indicate 'visited' oop. Unfortunately, it conflicts with Shenandoah, who uses the pattern to indicate 'forwarding'. When JV

RFR(L) 8237354: Add option to jcmd to write a gzipped heap dump

2020-02-07 Thread Schmelter, Ralf
Hi everyone, this change adds the option to write a hprof heap dump directly gzipped. Currently this is supported for the GC.heap_dump diagnostic command via the "-gz" flag. Since gzip is not particular fast when compressing the data, the actual compression will be done parallel in a bunch of

Re: RFR(S) 8238585: Use handshake for JvmtiEventControllerPrivate::enter_interp_only_mode() and don't make compiled methods on stack not_entrant

2020-02-07 Thread Vladimir Ivanov
Webrev: http://cr.openjdk.java.net/~rrich/webrevs/8238585/webrev.0/ Not an expert in JVMTI code base, so can't comment on the actual changes. From JIT-compilers perspective it looks good. Best regards, Vladimir Ivanov Bug:https://bugs.openjdk.java.net/browse/JDK-8238585 The change av