Hi Serguei,
Thanks for the review.
Thanks,
Fairoz
From: Serguei Spitsyn
Sent: Wednesday, February 19, 2020 1:57 AM
To: Fairoz Matte ; serviceability-dev@openjdk.java.net
Subject: Re: RFR (S) 8239055: Wrong implementation of VMState.hasListener
Hi Fairoz,
Looks good.
Thanks,
Serguei
On 2/13/
Re-post this RFR with correct enhancement number to make it trackable.
please ignore the previous wrong post. sorry for troubles.
webrev: http://cr.openjdk.java.net/~lzang/jmap-8214535/8215624/webrev_01/
bug: https://bugs.openjdk.java.net/browse/JDK-8215624
CSR: https://bugs.openjdk.java.net/brow
So sorry the number in this title is wrong. please ignore it !
so sorry about making this mistake.
will re post with correct number.
--
Lin
>Re-post this RFR with enhancement number to make it trackable.
>webrev: http://cr.openjdk.java.net/~lzang/jmap-8214535/8215264/webrev_01/
>bug:
Re-post this RFR with enhancement number to make it trackable.
webrev: http://cr.openjdk.java.net/~lzang/jmap-8214535/8215264/webrev_01/
bug: https://bugs.openjdk.java.net/browse/JDK-8215624
CSR: https://bugs.openjdk.java.net/browse/JDK-8239290
Thanks!
--
Lin
>Hi Lin,
>
>Could you, pl
On 2/18/20 4:15 PM, Ioi Lam wrote:
Hi Ralf,
We are usually pretty picky about adding new features into the JVM.
This seems to be an edge case (where your environment has more RAM
than disk). I think it would be better to handle this outside of the
JVM (using a named pipe and and external p
Hi Ralf,
We are usually pretty picky about adding new features into the JVM. This
seems to be an edge case (where your environment has more RAM than
disk). I think it would be better to handle this outside of the JVM
(using a named pipe and and external program such as the parallel gzip
"pigz
Hi Serguei,
On 2/18/20 3:53 PM, serguei.spit...@oracle.com wrote:
Hi Zhengyu,
It looks okay to me.
The testing you do looks enough for verification.
But I'm not sure about performance testing though.
Thanks for reviewing.
I asked around my colleagues, if they knew any benchmarks for JVMTI h
Hi Lin,
Could you, please, re-post your RFR with the right enhancement number in
the message subject?
It will be more trackable this way.
Thanks,
Serguei
On 2/17/20 10:29 PM, linzang(臧琳) wrote:
Dear David,
Thanks a lot!
I have updated the refined code to
http://cr.openjdk.jav
Hi Zhengyu,
It looks okay to me.
The testing you do looks enough for verification.
But I'm not sure about performance testing though.
Thanks,
Serguei
On 2/17/20 6:51 AM, Zhengyu Gu wrote:
Hi Stefan,
Thanks for the review and suggestions, updated accordingly:
http://cr.openjdk.java.net/~zgu/
Hi Fairoz,
Looks good.
Thanks,
Serguei
On 2/13/20 9:13 PM, Fairoz Matte wrote:
Hi,
Please review a tiny change to correct the VMState.hasListener
implementation.
JBS: https://bugs.openjdk.java.net/browse/JDK-8239055
Webrev: http://cr.openjdk.java.net/~fmatte/8239055/webrev.00/
Thanks,
Hi Roger,
It looks good to me.
Thanks,
Serguei
On 2/13/20 7:52 AM, Roger Riggs wrote:
Please review a minor cleanup to remove code long since unnecessary.
The type of the BadAttributeValueExpException argument is String and
if it is not a string in the serialized stream, a suitable replacemen
> On Feb 18, 2020, at 2:00 PM, Mandy Chung wrote:
>
>
>
> On 2/18/20 4:50 AM, Severin Gehwolf wrote:
>> Hi Mandy,
>>
>> Thanks again for the review!
>>
>> Updated webrev:
>> incremental (only review changes):
>> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-823/11/incremental/webre
On 2/18/20 4:50 AM, Severin Gehwolf wrote:
Hi Mandy,
Thanks again for the review!
Updated webrev:
incremental (only review changes):
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-823/11/incremental/webrev/
full: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-823/11/webrev/
Thi
Hi Mandy,
Thanks again for the review!
Updated webrev:
incremental (only review changes):
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-823/11/incremental/webrev/
full: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-823/11/webrev/
More below.
On Fri, 2020-02-14 at 18:16 -0800, Man
14 matches
Mail list logo
