Hi Chihiro,
Thank you for updating the webrev.
- You use BufferedWriter to create the output, however I think it would be
more simply if you use PrintWriter.
- Your change would work incorrectly when system property contains mixture of
ascii and non-ascii.
You can see it with "-Dmixt
Ralf and Christoph,
I agree that making it easy for the user is important, so dependency on
an external program like pgzip will be a hassle.
How about implementing the compression in a Java program? Will something
like this be too much of a hassle?
jcmd $PID GC.dump -stdout | java -jar
IMO the solution with goto makes it even worse.
If you don't want to introduce the wrapper, could you please restore
changes in LinuxDebuggerLocal_attach0 from webrev.1
--alex
On 02/21/2020 00:32, Baesken, Matthias wrote:
Hi Alex ,
new webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8
Hi Kim,
On 2/21/20 3:47 PM, Kim Barrett wrote:
On Feb 7, 2020, at 10:53 AM, Zhengyu Gu wrote:
Hi,
I would like purpose this change that allows GC to provide ObjectMarker during
JVMTI heap walk.
Currently, JVMTI heap walk uses oop markword's 'marked' pattern to indicate
'visited' oop.
Unfo
> On Feb 7, 2020, at 10:53 AM, Zhengyu Gu wrote:
>
> Hi,
>
> I would like purpose this change that allows GC to provide ObjectMarker
> during JVMTI heap walk.
>
> Currently, JVMTI heap walk uses oop markword's 'marked' pattern to indicate
> 'visited' oop.
>
> Unfortunately, it conflicts with
On 02/21/2020 00:09, Baesken, Matthias wrote:
Also I see GetStringUTFChars(str, JNI_FALSE). This look bad as well -
2nd arg is a pointer, so it should be NULL or nullptr.
Hi looks like there is another one here, do you think these JNI_FALSE params
would really cause trouble ? Not even the c
Hi all,
let me share my thoughts after going through this mail thread and interrogating
Ralf quite a bit about the feature 😉.
First of all, I very much value the discussion and the points brought up here.
When deciding about the introduction of an enhancement or a new feature, it's
always wise
Hi Yasumasa,
Thank you for your advice.
I decided not to use regular expressions. because of the number of \is
confusing.
I stopped using codePointAt() and used CharsetEncoder to work with ISO 8859
-1.
I added some environment variables to the test. However, environment
variables that contain mul
Ping :)
Richard.
-Original Message-
From: hotspot-compiler-dev On
Behalf Of Reingruber, Richard
Sent: Dienstag, 4. Februar 2020 09:59
To: David Holmes ; Vladimir Kozlov
(vladimir.koz...@oracle.com) ; Robbin Ehn
; serviceability-dev@openjdk.java.net;
hotspot-compiler-...@openjdk.java.
Adding serviceability-dev back.
Coleen
On 2/21/20 7:59 AM, coleen.phillim...@oracle.com wrote:
Hi, I had a quick look at this, minus the shenandoah code.
http://cr.openjdk.java.net/~zgu/JDK-8238633/webrev.01/src/hotspot/share/gc/shared/objectMarker.hpp.html
I think this file could have for
Hi Zhengyu,
On 2020-02-17 15:51, Zhengyu Gu wrote:
Hi Stefan,
Thanks for the review and suggestions, updated accordingly:
http://cr.openjdk.java.net/~zgu/JDK-8238633/webrev.01/
Thanks for moving the code. I think this looks good.
If you're up for it, I have a couple of style change suggesti
Hi Alex ,
new webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8239462.2/
Best Regards, Matthias
>
> Hi Matthias,
>
> Looks good in general, but I think it makes sense to fix #2 cases (at
> least I see them in LinuxDebuggerLocal). If GetStringUTFChars fails, the
> code will crash.
> Al
> Also I see GetStringUTFChars(str, JNI_FALSE). This look bad as well -
> 2nd arg is a pointer, so it should be NULL or nullptr.
Hi looks like there is another one here, do you think these JNI_FALSE params
would really cause trouble ? Not even the compiler warns here ...
src/java.desktop/unix/n
13 matches
Mail list logo
