Re: RFR: JDK-8240340: java/lang/management/ThreadMXBean/Locks.java is buggy

2020-03-08 Thread David Holmes
P.S. Forgot to note however that you need to update the documentation for the logger now as the mention of "per-thread logs" makes no sense now. Also in the spirit of not using @author, and because this is no longer the code created by Jaroslav, please delete the @author line. Thanks, David

Re: RFR: JDK-8240340: java/lang/management/ThreadMXBean/Locks.java is buggy

2020-03-08 Thread David Holmes
Hi Alex, On 6/03/2020 4:54 am, Alex Menkov wrote: Hi David, Thanks you for the review. On 03/04/2020 17:50, David Holmes wrote: Hi Alex, On 5/03/2020 10:30 am, Alex Menkov wrote: Hi all, please review the fix for https://bugs.openjdk.java.net/browse/JDK-8240340 webrev: http://cr.openjdk.ja

Re: PING: Re: RFR: JDK-8222489: jcmd VM.system_properties gives unusable paths on Windows

2020-03-08 Thread Chihiro Ito
Hi, I'm sorry. I included "JDK-" in the changeset title. I removed it and updated it. Change set : http://cr.openjdk.java.net/~cito/JDK-8222489/webrev.06/changeset Regards, Chihiro 2020年3月7日(土) 23:13 Chihiro Ito : > > Hi Serguei and Yasumasa, > > I update the copyright year and created the chan