Re: RFR: 8227269: Slow class loading when running JVM in debug mode

2020-03-09 Thread Chris Plummer
I'll have a look at it, although it might not be for a couple of days. Chris On 3/9/20 5:39 AM, Roman Kennke wrote: Hello all, Can I please get reviews of this change? In the meantime, we've done more testing and also field-/torture-testing by a customer who is happy now. :-) Thanks, Roman

RFR(L) 8238268: Many SA tests are not running on OSX because they do not attempt to use sudo when available

2020-03-09 Thread Chris Plummer
Hi, Please help review the following: https://bugs.openjdk.java.net/browse/JDK-8238268 http://cr.openjdk.java.net/~cjplummer/8238268/webrev.00/ I'll try to give enough background first to make it easier to understand the changes. On OSX you must run SA tests that attach to a live process as r

Re: RFR: JDK-8240340: java/lang/management/ThreadMXBean/Locks.java is buggy

2020-03-09 Thread David Holmes
Looks good. Thanks, David On 10/03/2020 5:15 am, Alex Menkov wrote: Updated webrev: http://cr.openjdk.java.net/~amenkov/jdk15/ThreadMXBean_Locks_test/webrev.02/ Changes are in LockFreeLogger comments only. --alex On 03/08/2020 21:19, David Holmes wrote: P.S. Forgot to note however that

Re: RFR: JDK-8240340: java/lang/management/ThreadMXBean/Locks.java is buggy

2020-03-09 Thread Alex Menkov
Updated webrev: http://cr.openjdk.java.net/~amenkov/jdk15/ThreadMXBean_Locks_test/webrev.02/ Changes are in LockFreeLogger comments only. --alex On 03/08/2020 21:19, David Holmes wrote: P.S. Forgot to note however that you need to update the documentation for the logger now as the mention

Re: RFR: JDK-8240340: java/lang/management/ThreadMXBean/Locks.java is buggy

2020-03-09 Thread Alex Menkov
On 03/06/2020 23:28, serguei.spit...@oracle.com wrote: Hi David and Alex, My understanding is that previous implementation collected logs separately for each thread in TLS, and at the end, merged and sorted out the output by log id. So, the result is that all messages are serialized at the

Re: RFR: 8227269: Slow class loading when running JVM in debug mode

2020-03-09 Thread Roman Kennke
Hello all, Can I please get reviews of this change? In the meantime, we've done more testing and also field-/torture-testing by a customer who is happy now. :-) Thanks, Roman > Hi Serguei, > > Thanks for reviewing! > > I updated the patch to reflect your suggestions, very good! > It also incl