On 16/03/2020 4:51 pm, Yasumasa Suenaga wrote:
On 2020/03/16 15:43, Chris Plummer wrote:
BTW, if you submit it to the submit repo, we can then go and run
additional internal tests (and even more builds) using that job.
Thanks for that tip Chris!
I've pushed the change to submit repo, but I've
On 3/15/20 11:51 PM, Yasumasa Suenaga wrote:
On 2020/03/16 15:43, Chris Plummer wrote:
BTW, if you submit it to the submit repo, we can then go and run
additional internal tests (and even more builds) using that job.
I've pushed the change to submit repo, but I've not yet received the
result.
Hi Roman,
Thank you for the update and sorry for the latency in review.
Some comments are below.
http://cr.openjdk.java.net/~rkennke/JDK-8227269/webrev.05/src/jdk.jdwp.agent/share/native/libjdwp/classTrack.c.frames.html
87 cbTrackingObjectF
On 2020/03/16 15:43, Chris Plummer wrote:
BTW, if you submit it to the submit repo, we can then go and run additional
internal tests (and even more builds) using that job.
I've pushed the change to submit repo, but I've not yet received the result.
I will share you when I get job ID.
Yasumasa
BTW, if you submit it to the submit repo, we can then go and run
additional internal tests (and even more builds) using that job.
Chris
On 3/15/20 11:36 PM, Yasumasa Suenaga wrote:
Hi David,
Thank you for testing it.
I updated webrev to avoid bailout to Java frame when DWARF has
language pe
Hi David,
Thank you for testing it.
I updated webrev to avoid bailout to Java frame when DWARF has language
personality routine or LSDA.
Could you try it?
http://cr.openjdk.java.net/~ysuenaga/JDK-8240956/webrev.01/
It works well on my Fedora 31 and Oracle Linux 7.7 .
I've pushed it to submi
Hi Chris,
Looks good.
Thank you for update!
Thanks,
Serguei
On 3/15/20 17:47, Chris Plummer wrote:
I changed them all to "SA Attach" and
grepped to make sure there are no other occurrences of "SA
at
Correction ...
On 16/03/2020 12:53 pm, David Holmes wrote:
On 16/03/2020 12:17 pm, David Holmes wrote:
Hi Yasumasa,
I can't review this as I know nothing about the code, but I'm putting
the patch through our internal testing.
Sorry but the crashes still exist:
#
# A fatal error has been de
On 16/03/2020 12:17 pm, David Holmes wrote:
Hi Yasumasa,
I can't review this as I know nothing about the code, but I'm putting
the patch through our internal testing.
Sorry but the crashes still exist:
#
# A fatal error has been detected by the Java Runtime Environment:
#
# SIGSEGV (0xb) at
Hi Yasumasa,
I can't review this as I know nothing about the code, but I'm putting
the patch through our internal testing.
David
On 14/03/2020 11:35 am, Yasumasa Suenaga wrote:
Hi all,
Please review this change:
JBS: https://bugs.openjdk.java.net/browse/JDK-8240956
webrev: http://cr.
I changed them all to "SA Attach" and
grepped to make sure there are no other occurrences of "SA
attach".
thanks,
Chris
On 3/15/20 4:49 PM, Igor Ignatyev wrote:
Hi Chris,
looks good, thanks!
Hi Chris,
looks good, thanks!
one minor nit, in SATestUtils::skipIfCannotAttach, you have two exception
messages which start with 'SA attach not expected to work.', and one w/ 'SA
Attach not expected to work.' (w/ Attach instead of attach), it'd be nicer to
have them uniform.
Cheers,
-- Igor
Hi Igor,
Thanks for the review. Here's and updated webrev with all of the
suggestions from you and Serguei:
http://cr.openjdk.java.net/~cjplummer/8238268/webrev.01/index.html
Also some comments inline below.
On 3/13/20 9:26 AM, Ig
13 matches
Mail list logo
