Re: RFR: 8240956: SEGV in DwarfParser::process_dwarf after JDK-8234624

Hi Yasumasa, The test has been problem listed so please add undoing this to your webrev. Here's the diff that problem listed it: diff --git a/test/hotspot/jtreg/ProblemList.txt b/test/hotspot/jtreg/ProblemList.txt --- a/test/hotspot/jtreg/ProblemList.txt +++ b/test/hotspot/jtreg/ProblemList.

Re: RFR(XS) 8241335: ProblemList serviceability/sa/ClhsdbPstack.java due to JDK-8240956

+1 Thanks, Serguei On 3/19/20 20:27, Mikael Vidstedt wrote: Looks good, thanks for doing this! Cheers, Mikael On Mar 19, 2020, at 8:25 PM, Chris Plummer wrote: Hello, Please review the following: diff --git a/test/hotspot/jtreg/ProblemList.txt b/test/hotspot/jtreg/ProblemList.txt --- a

Re: RFR(XS) 8241335: ProblemList serviceability/sa/ClhsdbPstack.java due to JDK-8240956

Looks good, thanks for doing this! Cheers, Mikael > On Mar 19, 2020, at 8:25 PM, Chris Plummer wrote: > > Hello, > > Please review the following: > > diff --git a/test/hotspot/jtreg/ProblemList.txt > b/test/hotspot/jtreg/ProblemList.txt > --- a/test/hotspot/jtreg/ProblemList.txt > +++ b/t

RFR(XS) 8241335: ProblemList serviceability/sa/ClhsdbPstack.java due to JDK-8240956

Hello, Please review the following: diff --git a/test/hotspot/jtreg/ProblemList.txt b/test/hotspot/jtreg/ProblemList.txt --- a/test/hotspot/jtreg/ProblemList.txt +++ b/test/hotspot/jtreg/ProblemList.txt @@ -115,7 +115,7 @@  serviceability/sa/ClhsdbPrintAll.java 8193639 solaris-all  serviceabil

Re: RFR (T) 8241320: The ClassLoaderData::_is_unsafe_anonymous field is unused in the SA

+1 Thanks, Serguei On 3/19/20 13:12, Lois Foltan wrote: Looks good. Lois On 3/19/2020 3:46 PM, coleen.phillim...@oracle.com wrote: Summary: remove unused code that is changing in Hotspot for hidden classes. Ran tier1-3 tests.  See bug for more details. open webrev at http://cr.openjdk.jav

Re: RFR: 8241123: Refactor vmTestbase stress framework to use j.u.c and make creation of threads more flexible

Than you for fixing. Then I do not need to see another webrev. Thanks, Serguei On 3/19/20 18:10, Leonid Mesnik wrote: Hi Thank you for review and feedback. See my comments inline. On Mar 1

Re: RFR: 8241123: Refactor vmTestbase stress framework to use j.u.c and make creation of threads more flexible

Hi Thank you for review and feedback. See my comments inline. > On Mar 19, 2020, at 6:03 PM, serguei.spit...@oracle.com wrote: > > Hi Leonid, > > It looks good in general. > Just a couple of comments. > > > http://cr.openjdk.java.net/~lmesnik/8241123/webrev.01/test/hotspot/jtreg/vmTestbase/ns

Re: RFR: 8241123: Refactor vmTestbase stress framework to use j.u.c and make creation of threads more flexible

Hi Leonid, It looks good in general. Just a couple of comments. http://cr.openjdk.java.net/~lmesnik/8241123/webrev.01/test/hotspot/jtreg/vmTestbase/nsk/share/Wicket.java.frames.html 168 public int waitFor(long timeout) { 169 if (timeou

Re: RFR (T) 8241320: The ClassLoaderData::_is_unsafe_anonymous field is unused in the SA

Hi Coleen, On 20/03/2020 5:46 am, coleen.phillim...@oracle.com wrote: Summary: remove unused code that is changing in Hotspot for hidden classes. I'm not sure how to identify unused code in the SA given that it exposes a Java API for querying the JVM internals. You say getisUnsafeAnonymous()

Re: RFR (T) 8241320: The ClassLoaderData::_is_unsafe_anonymous field is unused in the SA

Thanks Lois! Coleen On 3/19/20 4:12 PM, Lois Foltan wrote: Looks good. Lois On 3/19/2020 3:46 PM, coleen.phillim...@oracle.com wrote: Summary: remove unused code that is changing in Hotspot for hidden classes. Ran tier1-3 tests.  See bug for more details. open webrev at http://cr.openjdk.j

Re: RFR (T) 8241320: The ClassLoaderData::_is_unsafe_anonymous field is unused in the SA

Looks good. Lois On 3/19/2020 3:46 PM, coleen.phillim...@oracle.com wrote: Summary: remove unused code that is changing in Hotspot for hidden classes. Ran tier1-3 tests.  See bug for more details. open webrev at http://cr.openjdk.java.net/~coleenp/2020/8241320.01/webrev bug link https://bugs.

RFR (T) 8241320: The ClassLoaderData::_is_unsafe_anonymous field is unused in the SA

Summary: remove unused code that is changing in Hotspot for hidden classes. Ran tier1-3 tests.  See bug for more details. open webrev at http://cr.openjdk.java.net/~coleenp/2020/8241320.01/webrev bug link https://bugs.openjdk.java.net/browse/JDK-8241320 Thanks, Coleen

Re: RFR 8240902: JDI shared memory connector can use already closed Handles

On 3/19/20 11:22 AM, Daniel D. Daugherty wrote: > Inc: http://cr.openjdk.java.net/~pchilanomate/8240902/v2/inc/webrev/ >    (not sure why the indent fixes are not highlighted as changes but the Frames view does show they changed) By default, webrev ignores leading and trailing whitespace chan

Re: RFR 8240902: JDI shared memory connector can use already closed Handles

Thanks David! Patricio On 3/19/20 4:50 AM, David Holmes wrote: Hi Patricio, Incremental changes look good. Thanks, David On 19/03/2020 4:18 pm, Patricio Chilano wrote: Hi David, On 3/18/20 8:10 PM, David Holmes wrote: Hi Patricio, On 19/03/2020 6:44 am, Patricio Chilano wrote: Hi David,

Re: RFR 8240902: JDI shared memory connector can use already closed Handles

> Inc: http://cr.openjdk.java.net/~pchilanomate/8240902/v2/inc/webrev/ >    (not sure why the indent fixes are not highlighted as changes but the Frames view does show they changed) By default, webrev ignores leading and trailing whitespace changes. Use:     -b: Do not ignore changes in the am

Re: RFR 8240902: JDI shared memory connector can use already closed Handles

Hi Patricio, Incremental changes look good. Thanks, David On 19/03/2020 4:18 pm, Patricio Chilano wrote: Hi David, On 3/18/20 8:10 PM, David Holmes wrote: Hi Patricio, On 19/03/2020 6:44 am, Patricio Chilano wrote: Hi David, On 3/18/20 4:27 AM, David Holmes wrote: Hi Patricio, On 18/03/