RE: RFR(L) 8227745: Enable Escape Analysis for Better Performance in the Presence of JVMTI Agents

> Thanks for cleaning up thread.hpp! Thanks for providing the feedback! I justed noticed that the forward declaration of class jvmtiDeferredLocalVariableSet is not required anymore. Will remove it in the next webrev. Hope to get some more (partial) reviews. Thanks, Richard. -Original Me

RE: RFR(L) 8227745: Enable Escape Analysis for Better Performance in the Presence of JVMTI Agents

Hi Martin, > thanks for addressing all my points. I've looked over webrev.5 and I'm > satisfied with your changes. Thanks! > I had also promised to review the tests. Thanks++ I appreciate it very much, the tests are many lines of code. > test/jdk/com/sun/jdi/EATests.java > This is a substanti

Re: Review Request: 8238358: Implementation of JEP 371: Hidden Classes

Thanks to the review feedbacks. Updated webrev: http://cr.openjdk.java.net/~mchung/valhalla/webrevs/hidden-classes/webrev.04/ Delta between webrev.03 and webrev.04: http://cr.openjdk.java.net/~mchung/valhalla/webrevs/hidden-classes/webrev.03-delta/ Summary of changes is: 1. Update javac to retai

Re: Thread Local Handshake in JVMTI functions

Thanks Dan and Serguei! I added a comment for this to JDK-8201641. David, can you share Bug ID for thread-to-thread handshake? I want to record it to JDK-8201641 as a blocker. Yasumasa On 2020/04/01 1:59, serguei.spit...@oracle.com wrote: Hi Yasumasa, Yes, this works needs to be done. I'll

Re: RFR: 8240698: LingeredApp does not pass getTestJavaOpts() to the children process if vmArguments is already specified

Here is new webrev: http://cr.openjdk.java.net/~lmesnik/8240698/webrev.03/ The only difference is updated startApp() method and it's comments: http://cr.openjdk.java.net/~lmesnik/8240698/webrev.03/test/lib/jdk/test/lib/apps/LingeredApp.java

Re: Discussion about fixing deprecation in jdk.hotspot.agent

On 3/31/20 4:55 PM, Chris Plummer wrote: On 3/31/20 1:32 PM, coleen.phillim...@oracle.com wrote: On 3/31/20 12:19 PM, Poonam Parhar wrote: Hello Coleen, Does the removal of this code only impact the 'reattach' functionality, and it does not affect any commands available in 'clhsdb' once

Re: Discussion about fixing deprecation in jdk.hotspot.agent

On 3/31/20 1:32 PM, coleen.phillim...@oracle.com wrote: On 3/31/20 12:19 PM, Poonam Parhar wrote: Hello Coleen, Does the removal of this code only impact the 'reattach' functionality, and it does not affect any commands available in 'clhsdb' once it is attached to a core file? If that's tru

Re: RFR: 8240698: LingeredApp does not pass getTestJavaOpts() to the children process if vmArguments is already specified

On 3/31/20 12:09 PM, Leonid Mesnik wrote: Hi On 3/30/20 9:43 PM, Chris Plummer wrote: Hi Leonid, On 3/30/20 5:42 PM, Leonid Mesnik wrote: Hi See my comments inline. I will update webrev after go through all your comments. On 3/30/20 11:39 AM, Chris Plummer wrote: Hi Leonid, I haven't g

Re: Discussion about fixing deprecation in jdk.hotspot.agent

On 3/31/20 12:19 PM, Poonam Parhar wrote: Hello Coleen, Does the removal of this code only impact the 'reattach' functionality, and it does not affect any commands available in 'clhsdb' once it is attached to a core file? If that's true, then I think it should be okay to remove this code.

Re: Review Request: 8238358: Implementation of JEP 371: Hidden Classes

Alex's feedback:  rename isHiddenClass to isHidden as it can be a hidden class or interface. `isLocalClass` and `sAnonymousClass` are correct because the Java language only has local classes and anon classes, not local interfaces or anon. interfaces.  `isHidden` is like `isSynthetic`, it could

Re: RFR: 8240698: LingeredApp does not pass getTestJavaOpts() to the children process if vmArguments is already specified

Hi On 3/30/20 9:43 PM, Chris Plummer wrote: Hi Leonid, On 3/30/20 5:42 PM, Leonid Mesnik wrote: Hi See my comments inline. I will update webrev after go through all your comments. On 3/30/20 11:39 AM, Chris Plummer wrote: Hi Leonid, I haven't gone through all the tests yet.  I've accumu

Re: Review Request: 8238358: Implementation of JEP 371: Hidden Classes

This patch addresses Joe's feedback on the CSR [1]: http://cr.openjdk.java.net/~mchung/valhalla/webrevs/hidden-classes/webrev.03-delta-jdarcy/ Specifically, it adds to the class specification of java.lang.Class to describe how the relevant methods behave for hidden classes.  In addition, use t

Re: Thread Local Handshake in JVMTI functions

Hi Yasumasa, Yes, this works needs to be done. I'll take look at you webrev. Thanks, Serguei On 3/31/20 07:41, Daniel D. Daugherty wrote: Add Robbin to this thread... This reminded of the following RFE that Robbin filed:     JDK-8201641 JVMTI: GetThreadListStackTraces should use Thread-Loc

Re: Discussion about fixing deprecation in jdk.hotspot.agent

Hello Coleen, Does the removal of this code only impact the 'reattach' functionality, and it does not affect any commands available in 'clhsdb' once it is attached to a core file? If that's true, then I think it should be okay to remove this code. Thanks, Poonam On 3/31/20 5:34 AM, coleen.p

Re: Thread Local Handshake in JVMTI functions

Add Robbin to this thread... This reminded of the following RFE that Robbin filed:     JDK-8201641 JVMTI: GetThreadListStackTraces should use Thread-Local Handshakes     https://bugs.openjdk.java.net/browse/JDK-8201641 We could update 8201641 to include everything that Yasumasa-san is reque

Re: RFR(L) 8227745: Enable Escape Analysis for Better Performance in the Presence of JVMTI Agents

Thanks for cleaning up thread.hpp! /Robbin On 2020-03-30 10:31, Reingruber, Richard wrote: Hi, this is webrev.5 based on Robbin's feedback and Martin's review - thanks! :) The change affects jvmti, hotspot and c2. Partial reviews are very welcome too. Full: http://cr.openjdk.java.net/~rrich

RE: RFR(L) 8227745: Enable Escape Analysis for Better Performance in the Presence of JVMTI Agents

Hi Richard, thanks for addressing all my points. I've looked over webrev.5 and I'm satisfied with your changes. I had also promised to review the tests. test/hotspot/jtreg/serviceability/jvmti/Heap/IterateHeapWithEscapeAnalysisEnabled.java Thanks for updating the @summary comment. Looks good i

Re: Discussion about fixing deprecation in jdk.hotspot.agent

On 2020-03-31 14:34, coleen.phillim...@oracle.com wrote: To answer my own question, this functionality is used to allow detach/reattach from {cl}hsdb.  Which seems to work on linux but not windows with this code removed. The next question is whether this is useful functionality to justify

Re: Discussion about fixing deprecation in jdk.hotspot.agent

To answer my own question, this functionality is used to allow detach/reattach from {cl}hsdb.  Which seems to work on linux but not windows with this code removed. The next question is whether this is useful functionality to justify all this code (900+ and this new code that Magnus has adde

Re: Thread Local Handshake in JVMTI functions

Hi David, On 2020/03/31 19:16, David Holmes wrote: Hi Yasumasa, On 31/03/2020 8:06 pm, Yasumasa Suenaga wrote: Hi all, Many JVMTI functions uses VM Operation to get information. However some of them need to stop only one thread - they don't need to stop all threads. So I think we can use Thr

Re: Thread Local Handshake in JVMTI functions

Hi Yasumasa, On 31/03/2020 8:06 pm, Yasumasa Suenaga wrote: Hi all, Many JVMTI functions uses VM Operation to get information. However some of them need to stop only one thread - they don't need to stop all threads. So I think we can use Thread Local Handshake as this webrev. It is example fo

Thread Local Handshake in JVMTI functions

Hi all, Many JVMTI functions uses VM Operation to get information. However some of them need to stop only one thread - they don't need to stop all threads. So I think we can use Thread Local Handshake as this webrev. It is example for GetOneCurrentContendedMonitor(). http://cr.openjdk.java.n