On 2020/04/09 15:44, serguei.spit...@oracle.com wrote:
On 4/8/20 23:36, Yasumasa Suenaga wrote:
Thanks David and Serguei!
I created 3 subtasks under JDK-8201641, of course I will send review request in
each them.
- GetOneCurrentContendedMonitor => GetCurrentContendedMonitor
`GetCurrentCo
On 4/8/20 23:36, Yasumasa Suenaga wrote:
Thanks David and Serguei!
I created 3 subtasks under JDK-8201641, of course I will send review
request in each them.
- GetOneCurrentContendedMonitor => GetCurrentContendedMonitor
`GetCurrentContendedMonitor` is JVMTI function name, and also it
ex
Thanks David and Serguei!
I created 3 subtasks under JDK-8201641, of course I will send review request in
each them.
- GetOneCurrentContendedMonitor => GetCurrentContendedMonitor
`GetCurrentContendedMonitor` is JVMTI function name, and also it exists as
public member of JvmtiEnv class.
So
Hi Yasumasa,
I'm okay with using sub-tasks to do it incrementally.
This needs to be removed with your fix:
src/hotspot/share/runtime/vmOperations.hpp:
template(GetCurrentContendedMonitor) \
Also, I agree with comments from David below:
- GetOneCurrentContendedMonitor => GetCurre
Hi Yasumasa,
On 9/04/2020 3:08 pm, Yasumasa Suenaga wrote:
Hi,
JDK-8240918 has been pushed, so I made a patch for
GetCurrentContendedMonitor(). How about this?
http://cr.openjdk.java.net/~ysuenaga/jvmti-thread-local-handshake/2/
Generally looks okay. A couple of comments:
src/hotspot/s
Hi,
JDK-8240918 has been pushed, so I made a patch for
GetCurrentContendedMonitor(). How about this?
http://cr.openjdk.java.net/~ysuenaga/jvmti-thread-local-handshake/2/
An observation, it seems to me that calling_thread is not used when this is not
a VMOperation.
calling_thread is used
Ok. Thanks for the review!
Chris
On 4/8/20 8:04 PM, Yasumasa Suenaga wrote:
Yeah, it looks good!
I think this change is more safely.
Thanks,
Yasumasa
On 2020/04/09 11:57, Chris Plummer wrote:
Like this?
/* Dump the class file. */
try {
Yeah, it looks good!
I think this change is more safely.
Thanks,
Yasumasa
On 2020/04/09 11:57, Chris Plummer wrote:
Like this?
/* Dump the class file. */
try {
int index = fileName.lastIndexOf(File.separatorChar);
F
Thanks Yasumasa!
Chris
On 4/8/20 7:37 PM, Yasumasa Suenaga wrote:
Looks good!
Yasumasa
On 2020/04/09 11:08, Chris Plummer wrote:
Thanks Serguei!
Can I get one more review please?
thanks,
Chris
On 4/7/20 10:54 PM, serguei.spit...@oracle.com wrote:
Chris,
Refactored version looks nice.
I
Like this?
/* Dump the class file. */
try {
int index = fileName.lastIndexOf(File.separatorChar);
File dir = new File(fileName.substring(0, index));
dir.mkdirs();
try (FileOutputStream
Thanks, Chris!
Serguei
On 4/8/20 19:41, Chris Plummer wrote:
LGTM
Chris
On 4/8/20 7:15 PM, serguei.spit...@oracle.com wrote:
This is a one-liner fix. :)
Thanks,
Serguei
On 4/7/20 15:39, serguei.spit...@oracle.com wrote:
Please, review a fix for minor JDI enhancement:
https://bugs.openjdk.
LGTM
Chris
On 4/8/20 7:15 PM, serguei.spit...@oracle.com wrote:
This is a one-liner fix. :)
Thanks,
Serguei
On 4/7/20 15:39, serguei.spit...@oracle.com wrote:
Please, review a fix for minor JDI enhancement:
https://bugs.openjdk.java.net/browse/JDK-8242241
Webrev:
http://cr.openjdk.java.net
Looks good!
Yasumasa
On 2020/04/09 11:08, Chris Plummer wrote:
Thanks Serguei!
Can I get one more review please?
thanks,
Chris
On 4/7/20 10:54 PM, serguei.spit...@oracle.com wrote:
Chris,
Refactored version looks nice.
I was thinking to suggest the same in previous review but decided ther
Hi Chris,
CommandProcessor.java
1751 /* Dump the class file. */
1752 try {
1753 int index = fileName.lastIndexOf(File.separatorChar);
1754 File dir = new File(fileName.substring(0, index));
1755 dir.mkdir
This is a one-liner fix. :)
Thanks,
Serguei
On 4/7/20 15:39, serguei.spit...@oracle.com wrote:
Please, review a fix for minor JDI enhancement:
https://bugs.openjdk.java.net/browse/JDK-8242241
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/8242241-jdi-add-assert.1/
Summary:
A use
Thanks Serguei,
Can I get one more review please?
thanks,
Chris
On 4/7/20 10:19 PM, serguei.spit...@oracle.com wrote:
Hi Chris,
It looks good to me.
Thanks,
Serguei
On 4/7/20 20:12, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8240990
Thanks Serguei!
Can I get one more review please?
thanks,
Chris
On 4/7/20 10:54 PM, serguei.spit...@oracle.com wrote:
Chris,
Refactored version looks nice.
I was thinking to suggest the same in previous review but decided
there is not a big profit for small blocks of code.
But it is obviou
Ok. Thanks!
Chris
On 4/8/20 1:23 PM, Daniel D. Daugherty wrote:
Also, even though you did not ask for an "RFR(T)", I think this is
a trivial fix. You don't have to wait for 24 hours and can push when
you are happy with your testing.
Dan
On 4/8/20 4:21 PM, Daniel D. Daugherty wrote:
To reite
Also, even though you did not ask for an "RFR(T)", I think this is
a trivial fix. You don't have to wait for 24 hours and can push when
you are happy with your testing.
Dan
On 4/8/20 4:21 PM, Daniel D. Daugherty wrote:
To reiterate:
> Thumbs up.
Dan
On 4/8/20 4:07 PM, Chris Plummer wrote:
To reiterate:
> Thumbs up.
Dan
On 4/8/20 4:07 PM, Chris Plummer wrote:
Should I go ahead and push this, or do you want to see another review?
Chris
On 4/8/20 12:31 PM, Chris Plummer wrote:
It's possible, but I think given how our tests are run by CI it will
never happen. Also in order to me
Should I go ahead and push this, or do you want to see another review?
Chris
On 4/8/20 12:31 PM, Chris Plummer wrote:
It's possible, but I think given how our tests are run by CI it will
never happen. Also in order to mess up the test the output would need
to have an '=' in it. In general it's
It's possible, but I think given how our tests are run by CI it will
never happen. Also in order to mess up the test the output would need to
have an '=' in it. In general it's pretty easy to break our tests by
turning on things like logging or sprinkling debugging printfs the
hotspot or librar
Is it possible that some logging output that may occur after the key string
("-- listing properties --") is observed will confuse the test? I suspect
not, but I wanted to ask to be sure...
Thumbs up.
Dan
On 4/8/20 2:54 PM, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8242384
http://cr.openjdk.java.net/~cjplummer/8242384/webrev.00/
The failure was occurring when running the test with -Xlog:cds=debug,
which produced a logging output line that was mistaken for a property.
The test n
http://cr.openjdk.java.net/~iignatyev//8242313/webrev.00
> 16 lines changed: 10 ins; 0 del; 6 mod;
Hi all,
could you please review the patch which updates hotspot/jtreg/serviceability
tests in the same way as 8242310[1,2] updates compiler tests:
> marks ... tests w/ randomness k/w and uses Utils
25 matches
Mail list logo
