Re: RFR (S) 8074292: nsk/jdb/kill/kill001: generateOopMap.cpp assert(bb->is_reachable()) failed

Hi Coleen, On 14/04/2020 12:34 am, coleen.phillim...@oracle.com wrote: Summary: Do not install async exceptions at_safepoint for each bytecode. I'm still not certain that we have to go this far to solve this problem, but it does sound like a relatively simple solution provided there are no u

Re: RFR(XS) 8237250: pmap and pstack should do a better of making it clear that they are not supported on Mac OS X

Thanks! On 4/13/20 3:49 PM, serguei.spit...@oracle.com wrote: Hi Chris, LGTM++ Thanks, Serguei On 4/13/20 15:33, Alex Menkov wrote: LGTM --alex On 04/13/2020 13:30, Chris Plummer wrote: Ping! This one is pretty trivial. You don't really need to know anything about PMap and PStack to re

Re: RFR(XS) 8237250: pmap and pstack should do a better of making it clear that they are not supported on Mac OS X

Hi Chris, LGTM++ Thanks, Serguei On 4/13/20 15:33, Alex Menkov wrote: LGTM --alex On 04/13/2020 13:30, Chris Plummer wrote: Ping! This one is pretty trivial. You don't really need to know anything about PMap and PStack to review. It's just cleaning up how they fail due due not being sup

Re: RFR(XS) 8237250: pmap and pstack should do a better of making it clear that they are not supported on Mac OS X

LGTM --alex On 04/13/2020 13:30, Chris Plummer wrote: Ping! This one is pretty trivial. You don't really need to know anything about PMap and PStack to review. It's just cleaning up how they fail due due not being supported on OSX, and also adjusting the tests to detect the failure. thank

Re: RFR(XS) 8237250: pmap and pstack should do a better of making it clear that they are not supported on Mac OS X

Ping! This one is pretty trivial. You don't really need to know anything about PMap and PStack to review. It's just cleaning up how they fail due due not being supported on OSX, and also adjusting the tests to detect the failure. thanks, Chris On 4/9/20 3:55 PM, Chris Plummer wrote: Hello

Re: RFR(S) 8235220: ClhsdbScanOops.java fails with sun.jvm.hotspot.types.WrongTypeException

Thanks! On 4/13/20 12:48 PM, Alex Menkov wrote: Looks good. --alex On 04/13/2020 11:45, Chris Plummer wrote: Ping! Can I get one more review please. thanks, Chris On 4/9/20 10:21 PM, Ioi Lam wrote: Hi Chris, Thanks for fixing this. It looks good to me. - Ioi On 4/9/20 9:44 PM, Chris Pl

Re: RFR(S) 8235220: ClhsdbScanOops.java fails with sun.jvm.hotspot.types.WrongTypeException

Looks good. --alex On 04/13/2020 11:45, Chris Plummer wrote: Ping! Can I get one more review please. thanks, Chris On 4/9/20 10:21 PM, Ioi Lam wrote: Hi Chris, Thanks for fixing this. It looks good to me. - Ioi On 4/9/20 9:44 PM, Chris Plummer wrote: Hello, Please review the following:

Re: RFR(S) : 8242471 : remove "temporarily" restrictions of nsk/jdi/Argument/value/value004

Thanks Alex, pushed. -- Igor > On Apr 13, 2020, at 11:30 AM, Alex Menkov wrote: > > LGTM > > --alex > > On 04/13/2020 10:35, Igor Ignatyev wrote: >> sure. >> @alias, can I get a 2nd review for this patch? >> Thanks, >> -- Igor >>> On Apr 9, 2020, at 9:45 PM, Chris Plummer >>

Re: RFR(S/T) : 8242313 : use reproducible random in hotspot svc tests

Thanks Chris, pushed. -- Igor > On Apr 13, 2020, at 11:42 AM, Chris Plummer wrote: > > Looks good. > > thanks, > > Chris > > On 4/13/20 10:36 AM, Igor Ignatyev wrote: >> ping? >> -- Igor >> >>> On Apr 8, 2020, at 10:21 AM, Igor Ignatyev wrote: >>> >>> http://cr.openjdk.java.net/~iignatyev

Re: RFR(S) 8235220: ClhsdbScanOops.java fails with sun.jvm.hotspot.types.WrongTypeException

Ping! Can I get one more review please. thanks, Chris On 4/9/20 10:21 PM, Ioi Lam wrote: Hi Chris, Thanks for fixing this. It looks good to me. - Ioi On 4/9/20 9:44 PM, Chris Plummer wrote: Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8235220 http://cr.ope

Re: RFR(S/T) : 8242313 : use reproducible random in hotspot svc tests

Looks good. thanks, Chris On 4/13/20 10:36 AM, Igor Ignatyev wrote: ping? -- Igor On Apr 8, 2020, at 10:21 AM, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8242313/webrev.00 16 lines changed: 10 ins; 0 del; 6 mod; Hi all, could you please review the patch which updates ho

Re: RFR (S) 8074292: nsk/jdb/kill/kill001: generateOopMap.cpp assert(bb->is_reachable()) failed

Hi Martin, Thank you for testing this, the correction, and the code review. Coleen On 4/13/20 2:32 PM, Doerr, Martin wrote: Hi Coleen, thanks for implementing it for all platforms. PPC64: looks good. s390: The tm instruction produces a special condition code. z_brnaz should be used (plea

RE: RFR (S) 8074292: nsk/jdb/kill/kill001: generateOopMap.cpp assert(bb->is_reachable()) failed

Hi Coleen, thanks for implementing it for all platforms. PPC64: looks good. s390: The tm instruction produces a special condition code. z_brnaz should be used (please don't omit the 'a'). Tested interpreter safepoint polling by: jdk/bin/java -Xint -XX:-UseBiasedLocking -XX:+SafepointTimeout -

Re: RFR(S) : 8242471 : remove "temporarily" restrictions of nsk/jdi/Argument/value/value004

LGTM --alex On 04/13/2020 10:35, Igor Ignatyev wrote: sure. @alias, can I get a 2nd review for this patch? Thanks, -- Igor On Apr 9, 2020, at 9:45 PM, Chris Plummer > wrote: Hi Igor, I think it's best to get another review. thanks, Chris On 4/9/20 8:49

Re: RFR(S/T) : 8242313 : use reproducible random in hotspot svc tests

ping? -- Igor > On Apr 8, 2020, at 10:21 AM, Igor Ignatyev wrote: > > http://cr.openjdk.java.net/~iignatyev//8242313/webrev.00 >> 16 lines changed: 10 ins; 0 del; 6 mod; > > Hi all, > > could you please review the patch which updates hotspot/jtreg/serviceability > tests in the same way as 824

Re: RFR(S) : 8242471 : remove "temporarily" restrictions of nsk/jdi/Argument/value/value004

sure. @alias, can I get a 2nd review for this patch? Thanks, -- Igor > On Apr 9, 2020, at 9:45 PM, Chris Plummer wrote: > > Hi Igor, > > I think it's best to get another review. > > thanks, > > Chris > > On 4/9/20 8:49 PM, Igor Ignatev wrote: >> Thanks Chris! Would you consider this trivi

RFR (S) 8074292: nsk/jdb/kill/kill001: generateOopMap.cpp assert(bb->is_reachable()) failed

Summary: Do not install async exceptions at_safepoint for each bytecode. See CR for a lot more details.  This change calls a new InterpreterRuntime::at_safepoint_async_safe() which installs the async exception in the interpreter at backward branches and returns.  This uses safepoint polling co