On 4/14/20 10:56 PM, David Holmes wrote:
Hi Chris,
On 15/04/2020 1:37 pm, Chris Plummer wrote:
Hello,
[Sorry this email got kind of long. To cut to the chase, I want to
know if there are times where it is acceptable for SA to not be able
to produce a stack trace for a thread. Details below i
Hi Chris,
On 15/04/2020 1:37 pm, Chris Plummer wrote:
Hello,
[Sorry this email got kind of long. To cut to the chase, I want to know
if there are times where it is acceptable for SA to not be able to
produce a stack trace for a thread. Details below if you are interested.]
How does the SA c
On 14/04/2020 10:36 pm, coleen.phillim...@oracle.com wrote:
On 4/13/20 10:49 PM, David Holmes wrote:
Hi Coleen,
On 14/04/2020 12:34 am, coleen.phillim...@oracle.com wrote:
Summary: Do not install async exceptions at_safepoint for each bytecode.
I'm still not certain that we have to go this f
Hi Chris,
Thanks for the info. I've synced with the latest repo and updated the
webrev in-place:
http://cr.openjdk.java.net/~iklam/jdk15/8241158-sa-heap-dump-fails.v01/
I'll rerun tiers 1-4 as two of the affected tests (ClhsdbDumpheap.java,
TestHeapDumpForInvokeDynamic.java) will now be exec
Hello,
[Sorry this email got kind of long. To cut to the chase, I want to
know if there are times where it is acceptable for SA to not be able
to produce a stack trace for a thread. Details below if you are
interested.]
We have a number of SA tests that requ
Hi Magnus,
It looks good to me.
Thanks,
Serguei
On 4/14/20 14:23, Chris Plummer wrote:
Hi Magnus,
The changes look good. Just one minor issue:
http://cr.openjdk.java.net/~ihse/JDK-824161
[Not a review]
Hi Ioi,
Your ProblemList.txt is out of date. All those Solaris entries for
8193639 are now gone.
thanks,
Chris
On 4/14/20 3:01 PM, Ioi Lam wrote:
https://bugs.openjdk.java.net/browse/JDK-8241158
http://cr.openjdk.java.net/~iklam/jdk15/8241158-sa-heap-dump-fails.v01/
This is
https://bugs.openjdk.java.net/browse/JDK-8241158
http://cr.openjdk.java.net/~iklam/jdk15/8241158-sa-heap-dump-fails.v01/
This is a bug in the CDS relocation code. When
-XX:ArchiveRelocationMode=1 is
specified, the CDS archive is mapped to an address picked by the OS
(instead of the default addr
Hi Magnus,
The changes look good. Just one minor issue:
http://cr.openjdk.java.net/~ihse/JDK-8241618-fix-unchecked-warnings-for-agent/webrev.02/src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/Metadata.java.frames.html
Copyright was updated, but n
Hi Magnus,
Some minor mistakes below, but otherwise looks good. Also copyrights
need updating. I don't need to see another webrev.
thanks,
Chris
---
old/src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/MethodHandlesAdapterBlob.java
2020-04-14 12:47:05.098156117 +0200
+++
new/src/j
Hi Magnus,
This looks okay to me unless there is a better solution.
Thanks,
Serguei
On 4/14/20 04:04, Magnus Ihse Bursie wrote:
As a first step towards fixing deprecation warnings in SA, all the
references (200+) to the deprecated java.util.Observer and Observable
needs to be fixed, otherwise
Looks good to me (not familiar with all the code areas.
Minor suggestion:
MethodHandles.java
1811 * ASCII periods. For the instance of {@link java.lang.Class}
representing {@code C}:
1812 *
1813 * {@link Class#getName()} returns the string {@code GN + "/"
+ },
1814
Hello Magnus,
I'll let someone else judge the validity of the approach, though I think
it seems ok.
src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/GenericGrowableArray.java:
Double imports.
src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java:
Triple i
On 2020-04-14 14:44, coleen.phillim...@oracle.com wrote:
This looks good to me since we can't remove this.
Thanks for your review!
Does jdk.hotspot.agent follow the Hotspot review rules requiring two
Reviewers?
The patch complains that for your Observer.java:
\ No newline at end of file
Y
This looks good to me since we can't remove this. The patch complains
that for your Observer.java:
\ No newline at end of file
Thanks,
Coleen
On 4/14/20 7:04 AM, Magnus Ihse Bursie wrote:
As a first step towards fixing deprecation warnings in SA, all the
references (200+) to the deprecate
On 4/13/20 10:49 PM, David Holmes wrote:
Hi Coleen,
On 14/04/2020 12:34 am, coleen.phillim...@oracle.com wrote:
Summary: Do not install async exceptions at_safepoint for each bytecode.
I'm still not certain that we have to go this far to solve this
problem, but it does sound like a relati
As a first step towards fixing deprecation warnings in SA, all the
references (200+) to the deprecated java.util.Observer and Observable
needs to be fixed, otherwise all other changes will drown in this one.
This solution is the result of the preceding discussions in
serviceability-dev. That m
Hi,
Can I please get a review for this, simplified version of the patch?
This only contain trivial changes, like this:
- private Listobjects; // ArrayList
+ private List objects;
Basically all changes are to the container types List or Map (and a few
changes from Class to Class).
If
Hi Ralf,
thanks for providing this enhancement to parallel gzip-compress heap dumps!
I reckon it's safe to say that the coding is sophisticated. It would be awesome
if you could sketch
the idea of how HeapDumper, DumpWriter and CompressionBackend work together to
produce the gzipped
dump in a s
19 matches
Mail list logo
