Hi Daniil,
LGTM++
Thanks,
Serguei
On 4/17/20 14:14, Chris Plummer wrote:
Looks good.
Chris
On 4/17/20 1:03 PM, Daniil Titov wrote:
Please review the change that fixes intermittent failure of
java/lang/management/ThreadMXBean/MaxDepthForThreadInfoTest.java
As David noticed (thank you, Dav
On 4/17/20 16:52, Mandy Chung wrote:
On 4/17/20 3:51 PM, Chris Plummer wrote:
Hi Mandy,
Thanks for updating the svc specs. Some comments below:
In the JDWP spec update, you changed "JNI signature" to "type
signature" in one place, but left it as "JNI signature" everywhere
else. Should the
On 4/17/20 3:51 PM, Chris Plummer wrote:
Hi Mandy,
Thanks for updating the svc specs. Some comments below:
In the JDWP spec update, you changed "JNI signature" to "type
signature" in one place, but left it as "JNI signature" everywhere
else. Should they all be changed?
JDWP signature i
On 4/16/20 9:45 AM, Mandy Chung wrote:
On 4/14/20 11:51 AM, Paul Sandoz wrote:
Looks good to me (not familiar with all the code areas.
Minor suggestion:
MethodHandles.java
1811 * ASCII periods. For the instance of {@link
java.lang.Class} representing {@code C}:
1812 *
181
Looks good.
Chris
On 4/17/20 1:03 PM, Daniil Titov wrote:
Please review the change that fixes intermittent failure of
java/lang/management/ThreadMXBean/MaxDepthForThreadInfoTest.java
As David noticed (thank you, David, for this analysis) there is no guarantee
that all threads found by getAll
Please review the change that fixes intermittent failure of
java/lang/management/ThreadMXBean/MaxDepthForThreadInfoTest.java
As David noticed (thank you, David, for this analysis) there is no guarantee
that all threads found by getAllThreadIds() are still alive by the time we call
getThreadInfo
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8242789
http://cr.openjdk.java.net/~cjplummer/8242789/webrev.00
JShellHeapDumpTest.java has two variants, one that does a short 2 second
sleep after launching the jshell process (the main
JShellHeapDumpTest.java test
Thanks Severin and David for your review.
Will push it tomorrow.
Best regards,
Jie
On 2020/4/17, 8:56 PM, "David Holmes" wrote:
On 17/04/2020 5:00 pm, jiefu(傅杰) wrote:
> Hi David,
>
> Updated: http://cr.openjdk.java.net/~jiefu/8242480/webrev.02/
>
> The file header h
On 17/04/2020 5:00 pm, jiefu(傅杰) wrote:
Hi David,
Updated: http://cr.openjdk.java.net/~jiefu/8242480/webrev.02/
The file header had been fixed. Please review it.
File header update looks good.
Thanks,
David
Thanks a lot.
Best regards,
Jie
On 2020/4/17, 11:59 AM, "David Holmes" wrote:
On 4/17/20 4:58 AM, serguei.spit...@oracle.com wrote:
Hi Coleen,
LGTM++
On 4/16/20 18:47, David Holmes wrote:
Hi Coleen,
Still LGTM. The other guarded methods are only called from JVMTI
code. The two that are now stubbed out would have been no-ops without
JVMTI as old_compiled_method_ta
On 4/16/20 9:47 PM, David Holmes wrote:
Hi Coleen,
Still LGTM. The other guarded methods are only called from JVMTI code.
The two that are now stubbed out would have been no-ops without JVMTI
as old_compiled_method_table would have been NULL.
Yes, that is true. I considered #if INCLUDE_J
Hi Coleen,
LGTM++
On 4/16/20 18:47, David Holmes wrote:
Hi Coleen,
Still LGTM. The other guarded methods are only called from JVMTI code.
The two that are now stubbed out would have been no-ops without JVMTI
as old_compiled_method_table would have been NULL.
Still seems trivial to me.
T
On Fri, 2020-04-17 at 06:58 +, jiefu(傅杰) wrote:
> Updated: http://cr.openjdk.java.net/~jiefu/8242480/webrev.02/
Looks good.
Thanks,
Severin
Hi David,
Updated: http://cr.openjdk.java.net/~jiefu/8242480/webrev.02/
The file header had been fixed. Please review it.
Thanks a lot.
Best regards,
Jie
On 2020/4/17, 11:59 AM, "David Holmes" wrote:
Hi Jie,
On 16/04/2020 11:23 pm, jiefu(傅杰) wrote:
> Hi Severin,
>
>
Hi Severin,
Updated: http://cr.openjdk.java.net/~jiefu/8242480/webrev.02/
Please review it.
Thanks a lot.
Best regards,
Jie
On 2020/4/16, 11:40 PM, "Severin Gehwolf" wrote:
Since you've added a new test, please move them to the jdk docker tests
in:
test/jdk/jdk/internal/plat
15 matches
Mail list logo
