Re: RFR (M) Close alignment gaps in InstanceKlass

Hi Coleen.  The JVMCI changes look OK.  It looks like there is a Graal unittest that covers getSourceFileName, but those tests don't always get run.  If it's not too much trouble, could you look into enabling getSourceFileName() testing in

Re: RFR(XS) 8243210: ClhsdbScanOops fails with NullPointerException in FileMapHeader.inCopiedVtableSpace

Hi Chris, It looks reasonable. Thanks, Serguei On 4/21/20 16:07, Chris Plummer wrote: Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8243210 http://cr.openjdk.java.net/~cjplummer/8243210/webrev.01/index.html Description is in the bug. Hopefully this is the

Re: RFR(L): 8215624: add parallel heap inspection support for jmap histo(G1)

Dear all, May I ask you help to review? This RFR has been there for quite a while. Thanks! BRs, Lin > On 2020/3/16, 5:18 PM, "linzang(臧琳)" wrote:> > Just update a new path, my preliminary measure show about 3.5x speedup of > jmap histo on a nearly full 4GB G1 heap (8-core

RFR(XS) 8243210: ClhsdbScanOops fails with NullPointerException in FileMapHeader.inCopiedVtableSpace

Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8243210 http://cr.openjdk.java.net/~cjplummer/8243210/webrev.01/index.html Description is in the bug. Hopefully this is the last in a series of about 6 bugs being addressed that finally lets us get this test off the

Re: RFR (M) Close alignment gaps in InstanceKlass

On 4/21/20 4:41 PM, Chris Plummer wrote: Hi Coleen, The SA changes look good. BTW, I've already made the TestIntConstant.java change in the Loom project. InstanceKlass::_misc_is_unsafe_anonymous was already changed to "8" in loom. You might want to sync up with Ron to make sure you aren't

Re: RFR (M) Close alignment gaps in InstanceKlass

On 4/21/20 4:41 PM, Chris Plummer wrote: Hi Coleen, The SA changes look good. BTW, I've already made the TestIntConstant.java change in the Loom project. InstanceKlass::_misc_is_unsafe_anonymous was already changed to "8" in loom. You might want to sync up with Ron to make sure you aren't

Re: RFR (M) Close alignment gaps in InstanceKlass

Hi Coleen, The SA changes look good. BTW, I've already made the TestIntConstant.java change in the Loom project. InstanceKlass::_misc_is_unsafe_anonymous was already changed to "8" in loom. You might want to sync up with Ron to make sure you aren't making conflicting changes in this area.

RFR (M) Close alignment gaps in InstanceKlass

Summary: moved fields around and some constant fields into ConstantPool This is a simple change except that I moved some constant fields from InstanceKlass into the constant pool so they can be shared read-only in the CDS archive.  There are associated repercussions in SA and JVMCI, so please

RFR (S) 8243244: CSR Add option to jcmd to write a gzipped heap dump

Hi, I need a review for the following CSR: https://bugs.openjdk.java.net/browse/JDK-8243244 It describes the two additional options added to the GC.heap_dump command to support gzipped heap dumps. Best regards, Ralf

Re: RFR: JDK-8242943 Fix all remaining unchecked warnings in jdk.hotspot.agent

On 2020-04-20 21:19, Joe Darcy wrote: Hello, On 4/16/2020 5:47 AM, Magnus Ihse Bursie wrote: [snip] The tricky one here is the helper TableModelComparator. This one took me a while to wrap my head around. It implements Comparator, but the compare() method takes "rows" from the model, which

RE: RFR(L) 8237354: Add option to jcmd to write a gzipped heap dump

Hi Ralf, I've just started a closer review of your change, based on your current webrev. I'm not done yet but hope I'll find the time to finish this in the next few days. However, as this patch seems in a quite good condition already and we're targeting JDK15, could you please start creating