Re: RFR: 8242239: [Graal] javax/management/generified/GenericTest.java fails: FAILED: queryMBeans sets same

2020-04-25 Thread serguei.spit...@oracle.com
Hi Daniil, Thank you for the update. On 4/24/20 22:22, Daniil Titov wrote: Hi Chris and Serguei, Please review a new version of the fix [1] that makes the tests try to repeat the check only once. Regarding the question Serguei asked:

Re: RFR(S) 8238585: Use handshake for JvmtiEventControllerPrivate::enter_interp_only_mode() and don't make compiled methods on stack not_entrant

2020-04-25 Thread Patricio Chilano
Hi Richard, On 4/24/20 6:41 PM, Reingruber, Richard wrote: Hi Patricio, @Patricio, coming back to my question [1]: In the example you gave in your answer [2]: the java thread would execute a vm operation during a direct handshake operation, while the VMThread is actually in the middle of a

RE: RFR(S) 8238585: Use handshake for JvmtiEventControllerPrivate::enter_interp_only_mode() and don't make compiled methods on stack not_entrant

2020-04-25 Thread Reingruber, Richard
Hi Patricio, thanks a lot for all the explanations. At least to me they are really helpful. :) Cheers, Richard. -Original Message- From: Patricio Chilano Sent: Samstag, 25. April 2020 11:23 To: Reingruber, Richard ; Yasumasa Suenaga ; serguei.spit...@oracle.com; Vladimir Ivanov ; se

Re: RFR(S/T) : 8243568 : serviceability/logging/TestLogRotation.java uses 'test.java.opts' and not 'test.vm.opts'

2020-04-25 Thread Igor Ignatev
Thanks Chris. I can’t help but wonder if we should move all tests from serviceability/logging to runtime then. — Igor > On Apr 24, 2020, at 3:53 PM, Chris Plummer wrote: > > Adding hotspot-runtime-dev since logging is owned by runtime, not > serviceability. > > Chris > >> On 4/24/20 3:41

Re: RFR: 8242239: [Graal] javax/management/generified/GenericTest.java fails: FAILED: queryMBeans sets same

2020-04-25 Thread Daniil Titov
Hi Serguei, Please review a new version of the webrev [1] that changes the condition as you suggested. Please note then in both cases we need break from the loop : the case when it is a first attempt and the conditions are met and the case when it is a second attempt. [1] http://cr.openjdk.

Re: RFR: 8242239: [Graal] javax/management/generified/GenericTest.java fails: FAILED: queryMBeans sets same

2020-04-25 Thread serguei.spit...@oracle.com
Hi Daniil, Thank you for the update. It looks good. Thanks, Serguei On 4/25/20 09:11, Daniil Titov wrote: Hi Serguei, Please review a new version of the webrev [1] that changes the condition as you suggested. Please note then in both cases we need break from the loop : the case when it is

Re: RFR(L): 8215624: add parallel heap inspection support for jmap histo(G1)(Internet mail)

2020-04-25 Thread 臧琳
Hi Stefan and Paul, I have made a new patch based on your comments and Stefan's Poc code: Webrev: http://cr.openjdk.java.net/~lzang/jmap-8214535/8215624/webrev_03/ Delta(based on Stefan's change:) : http://cr.openjdk.java.net/~lzang/jmap-8214535/8215624/webrev_03-delta/webrev_03-delt