Re: RFR: JDK-8242522: Minor LingeredApp improvements

Hi Alex, Looks good except for one minor nit:  249 if (epoch - here > (timeout)) { No needs for the parens around "timeout". I don't need to see another webrev. thanks, Chris On 4/27/20 5:36 PM, Alex Menkov wrote: updated webrev: http://cr.openjdk.java.net/~amenkov/jdk15/Linge

Re: RFR(T) : 8243929 : use @requires in serviceability/attach/AttachWithStalePidFile.java test

Hi Igor, Looks good except copyright needs updating. cheers, Chris On 4/27/20 4:58 PM, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8243929/webrev.00 7 lines changed: 1 ins; 6 del; 0 mod; Hi all, could you please review this trivial patch which updates AttachWithStalePidFil

Re: RFR(T) : 8244052 : remove copying of s.h.WB$WhiteBoxPermission in test/jdk

LGTM++ Thanks, Serguei On 4/28/20 23:28, David Holmes wrote: Looks good! Thanks, David On 29/04/2020 1:20 pm, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8244052/webrev.00/ 34 lines changed: 0 ins; 11 del; 23 mod; Hi all, could you please review this trivial patch? from

Re: RFR(T) : 8244052 : remove copying of s.h.WB$WhiteBoxPermission in test/jdk

Looks good! Thanks, David On 29/04/2020 1:20 pm, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8244052/webrev.00/ 34 lines changed: 0 ins; 11 del; 23 mod; Hi all, could you please review this trivial patch? from JBS: JDK-8199290 made it unnecessary to explicitly pass sun.hot

RFR(T) : 8244052 : remove copying of s.h.WB$WhiteBoxPermission in test/jdk

http://cr.openjdk.java.net/~iignatyev//8244052/webrev.00/ > 34 lines changed: 0 ins; 11 del; 23 mod; Hi all, could you please review this trivial patch? from JBS: > JDK-8199290 made it unnecessary to explicitly pass > sun.hotspot.WhiteBox$WhiteBoxPermission as an argument to ClassFileInstaller

Re: RFR (L): 8241807: JDWP needs update for hidden classes

On 4/28/20 18:14, Alex Menkov wrote: On 04/28/2020 18:03, serguei.spit...@oracle.com wrote: Hi Alex, Thank you a lot for reviewing this. On 4/28/20 17:35, Alex Menkov wrote: Hi Serguei, Looks good in general. couple minor notes: DebuggerBase.java - vm, debuggee, pipe and erManager field

Re: RFR (L): 8241807: JDWP needs update for hidden classes

Hi Alex, The updated webrev version is: http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/valhalla-jdi-events.6/ I'll push it if you have no objections. Thanks, Serguei On 4/28/20 18:03, serguei.spit...@oracle.com wrote: Hi Alex, Thank you a lot for reviewing this. On 4/28/20 17:35, Alex

Re: RFR (L): 8241807: JDWP needs update for hidden classes

On 04/28/2020 18:03, serguei.spit...@oracle.com wrote: Hi Alex, Thank you a lot for reviewing this. On 4/28/20 17:35, Alex Menkov wrote: Hi Serguei, Looks good in general. couple minor notes: DebuggerBase.java - vm, debuggee, pipe and erManager fields and getDebuggee(), vm() methods do

Re: RFR (L): 8241807: JDWP needs update for hidden classes

Hi Alex, Thank you a lot for reviewing this. On 4/28/20 17:35, Alex Menkov wrote: Hi Serguei, Looks good in general. couple minor notes: DebuggerBase.java - vm, debuggee, pipe and erManager fields and getDebuggee(), vm() methods don't need to be static; Thank you for the suggestion. The

Re: RFR (L): 8241807: JDWP needs update for hidden classes

Hi Serguei, Looks good in general. couple minor notes: DebuggerBase.java - vm, debuggee, pipe and erManager fields and getDebuggee(), vm() methods don't need to be static; - replace all "imultiple" with "multiple". --alex On 04/27/2020 18:34, serguei.spit...@oracle.com wrote: Hi Leonid,

RFR(T) JDK-8214797: TestJmapCoreMetaspace.java timed out

Hello, Please review the following trivial change: diff --git a/test/hotspot/jtreg/serviceability/sa/TestJmapCoreMetaspace.java b/test/hotspot/jtreg/serviceability/sa/TestJmapCoreMetaspace.java --- a/test/hotspot/jtreg/serviceability/sa/TestJmapCoreMetaspace.java +++ b/test/hotspot/jtreg/serv

Re: RFR(M) 8243500: SA: Incorrect BCI and Line Number with jstack if the top frame is in the interpreter (BSD and Windows)

Yeah, it took a while for me to come up with a reasonable test. It possibly could use some tuning. I first required it match 5 out of 5 lines, and do so in 30 seconds. Then I realized that a fixed time wasn't a good idea, nor matching every line. It failed frequently, mostly on slower machines

Re: RFR(M) 8243500: SA: Incorrect BCI and Line Number with jstack if the top frame is in the interpreter (BSD and Windows)

Hi Chris, LGTM++ The test is interesting. Thanks, Serguei On 4/28/20 12:16, Chris Plummer wrote: Thanks Alex! Can I get one more review please? Chris On 4/27/20 6:52 PM, Alex Menkov wrote: Hi Chris, The fix looks good. --alex On 04/27/2020 12:17, Chris Plummer wrote: Ping! Please hel

Re: Fwd: RFR(S) 8231634: SA stack walking fails with "illegal bci"

Thanks Alex and Serguei! Chris On 4/27/20 6:23 PM, Alex Menkov wrote: Hi Chris, great analysis. LGTM++ --alex On 04/27/2020 14:52, serguei.spit...@oracle.com wrote: Hi Chris, The fix looks reasonable. Thanks, Serguei On 4/27/20 12:16, Chris Plummer wrote: Ping! Please help review if you

Re: RFR(M) 8243500: SA: Incorrect BCI and Line Number with jstack if the top frame is in the interpreter (BSD and Windows)

Thanks Alex! Can I get one more review please? Chris On 4/27/20 6:52 PM, Alex Menkov wrote: Hi Chris, The fix looks good. --alex On 04/27/2020 12:17, Chris Plummer wrote: Ping! Please help review if you can. thanks, Chris On 4/24/20 12:44 AM, Chris Plummer wrote: Hello, Please review

Re: RFR (L): 8241807: JDWP needs update for hidden classes

Thanks a lot! Serguei On 4/28/20 11:29, Leonid Mesnik wrote: Looks good. Leonid On 4/27/20 6:34 PM, serguei.spit...@oracle.com wrote: Hi Leonid, Updated webrev version with the suggest

Re: RFR (L): 8241807: JDWP needs update for hidden classes

Looks good. Leonid On 4/27/20 6:34 PM, serguei.spit...@oracle.com wrote: Hi Leonid, Updated webrev version with the suggested refactoring is: http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/valhalla-jdi-events.5/ <

Re: URGENT (trivial) RFR: 8243989: test/hotspot/jtreg/serviceability/jvmti/CanGenerateAllClassHook/CanGenerateAllClassHook.java needs to use othervm

Thanks Martin! David On 28/04/2020 7:43 pm, Doerr, Martin wrote: Hi David, looks good and trivial. Best regards, Martin -Original Message- From: hotspot-dev On Behalf Of David Holmes Sent: Dienstag, 28. April 2020 11:39 To: hotspot-dev developers ; serviceability-dev Subject: URG

RE: URGENT (trivial) RFR: 8243989: test/hotspot/jtreg/serviceability/jvmti/CanGenerateAllClassHook/CanGenerateAllClassHook.java needs to use othervm

Hi David, looks good and trivial. Best regards, Martin > -Original Message- > From: hotspot-dev On Behalf Of > David Holmes > Sent: Dienstag, 28. April 2020 11:39 > To: hotspot-dev developers ; > serviceability-dev > Subject: URGENT (trivial) RFR: 8243989: > test/hotspot/jtreg/service

URGENT (trivial) RFR: 8243989: test/hotspot/jtreg/serviceability/jvmti/CanGenerateAllClassHook/CanGenerateAllClassHook.java needs to use othervm

https://bugs.openjdk.java.net/browse/JDK-8243989 diff -r 5dfc5e2f1bfc test/hotspot/jtreg/serviceability/jvmti/CanGenerateAllClassHook/CanGenerateAllClassHook.java --- a/test/hotspot/jtreg/serviceability/jvmti/CanGenerateAllClassHook/CanGenerateAllClassHook.java +++ b/test/hotspot/jtreg/service