B/c @modules affect all actions, such location can confuse people into thinking
that it affects only the next one (or all the following).
— Igor
> On May 2, 2020, at 8:46 AM, Alan Bateman wrote:
>
> On 02/05/2020 16:39, Igor Ignatyev wrote:
>> Hi Alan,
>>
>> it looks good, but could you
On 02/05/2020 16:39, Igor Ignatyev wrote:
Hi Alan,
it looks good, but could you please put @modules tags right before
@library?
Okay but the reason I moved it down here is because there's an @run
driver in the sequence of actions and the @modules that we are adding
here is only interesting
Hi Alan,
it looks good, but could you please put @modules tags right before @library? we
are trying to follow the recommend order (
http://hg.openjdk.java.net/code-tools/jtreg/raw-file/e235ed803708/src/share/doc/javatest/regtest/tag-spec.html#ORDER
I need a reviewer for an tiny update to two tests in
test/hotspot/jtreg/vmTestbase/ndk/jdi. Both tests need the non-exported
package com.sun.tools.jdi to be opened because they instantiate
ObjectReferenceImpl via its non-public constructor. This change is
needed in advance of denying illegal
In ClassLoader::crc32, instead of checking if the library is loaded
every time, how about initializing the Crc32 function pointer to a
function that calls load_zip_library()?
Something like:
static jint initial_Crc32(jint crc, const jbyte *buf, jint len) {
load_zip_library();
