On 5/5/20 17:04, Mikael Vidstedt wrote:
On May 5, 2020, at 4:48 PM, serguei.spit...@oracle.com wrote:
Hi Mikael,
The fixes in webrev look good to me.
I've just noticed a couple of more serviceability related things can be missed.
(Not sure if they are included into different chunk of
> On May 5, 2020, at 4:48 PM, serguei.spit...@oracle.com wrote:
>
> Hi Mikael,
>
> The fixes in webrev look good to me.
>
> I've just noticed a couple of more serviceability related things can be
> missed.
> (Not sure if they are included into different chunk of fixes.)
>
> One is
Hi Mikael,
The fixes in webrev look good to me.
I've just noticed a couple of more serviceability related things can be
missed.
(Not sure if they are included into different chunk of fixes.)
One is libjvm_db.so which is for Solaris Pstack support:
Ioi, Calvin
Thanks. The inline sometime prefix to function declaration sometimes
not. I will put inline without updating webrev.
Thanks
Yumin
On 5/5/20 2:23 PM, Ioi Lam wrote:
Hi Yumin,
258 static void load_zip_library_if_needed();
I think "inline" should be added to the declaration.
All good points! I deliberately chose *not* to update comments where it wasn’t
immediately 100% obvious exactly how to update them. For example, in many cases
I found that the comments are already incomplete or stale, and for each such
case we’ll want to consider how exactly to update the
Hi Yumin,
258 static void load_zip_library_if_needed();
I think "inline" should be added to the declaration. It probably doesn't
matter, but we usually add 'inline' to the declaration of functions that
appear in xxx_inline.hpp files.
Thanks
- Ioi
On 5/5/20 1:32 PM, Yumin Qi wrote:
Hi,
Looks good.
thanks,
Calvin
On 5/5/20 1:32 PM, Yumin Qi wrote:
Hi, Ioi and Calvin
There is an file classLoader.inline.hpp which also includes
atomic.hpp. I put load_zip_library_if_needed in it. Updated webrev:
http://cr.openjdk.java.net/~minqi/8237750/webrev-03/
Also, double checked the
Hi, Ioi and Calvin
There is an file classLoader.inline.hpp which also includes
atomic.hpp. I put load_zip_library_if_needed in it. Updated webrev:
http://cr.openjdk.java.net/~minqi/8237750/webrev-03/
Also, double checked the function is not in libjvm.so by
nm libjvm.so | grep
On 5/5/20 10:59 AM, Ioi Lam wrote:
Hi Yumin,
Looks good.
Just small nits. No need for new webrev.
[1] I think this should be named _libzip_loaded to be consistent with
other fields
static int libzip_loaded; // used to sync loading zip.
[2] This introduces dependency on
Hi Leonid,
It looks okay to me.
Thanks,
Serguei
On 5/4/20 18:15, Leonid Mesnik wrote:
Hi
Could you please review following fix which add all quick and stable
serviceability tests in tier1. The tier1_serviceability still takes
less than 15 minutes on 2 cores i5.
The tests with
Hi Yumin,
Looks good.
Just small nits. No need for new webrev.
[1] I think this should be named _libzip_loaded to be consistent with
other fields
static int libzip_loaded; // used to sync loading zip.
[2] This introduces dependency on atomic.hpp to classLoader.hpp
static
Hi Leonid,
Looks good. Thanks for fixing this.
Chris
On 5/4/20 6:15 PM, Leonid Mesnik wrote:
Hi
Could you please review following fix which add all quick and stable
serviceability tests in tier1. The tier1_serviceability still takes
less than 15 minutes on 2 cores i5.
The tests with
12 matches
Mail list logo
