On 5/23/20 6:03 AM, David Holmes wrote:
Hi Chris,
On 23/05/2020 4:50 am, Chris Plummer wrote:
Hi Daniil,
There is one reference to "jvmwarningmsg" that occurs before it is
declared while all the rest all come after. It probably would make
sense to move its declaration up near the top of the
Hi Chris,
On 23/05/2020 4:50 am, Chris Plummer wrote:
Hi Daniil,
There is one reference to "jvmwarningmsg" that occurs before it is
declared while all the rest all come after. It probably would make sense
to move its declaration up near the top of the file.
92 private static void
Update looks fine - though I see you already pushed it.
David
On 22/05/2020 7:32 pm, serguei.spit...@oracle.com wrote:
Hi David,
The updated webrev is with your comments addressed:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/8244571-jvmti-test-jnicheck.2/
Thanks,
Serguei
On
On 23/05/2020 01:15, Alex Menkov wrote:
size of utf8 string does not depend on sizeof(int).
Per RFC each symbol can be encoded by 1..4 byte(s).
Maybe Alan can explain this len+len/2+2 value.
I don't know without digging into the history. My only reason for
pointing it out is that it looked